Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-16494

Check fileset for operations by fid

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.16.0
    • Lustre 2.16.0
    • 3
    • 9223372036854775807

    Description

      Some operations by FID, such as lfs rmfid, must be aware of subdirectory mount (fileset) so that they do not operate on files that are outside of the namespace currently mounted by the client.

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-8585 All Lustre test suites should pass with subdirectory mount

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            [LU-16494] Check fileset for operations by fid
            pjones Peter Jones added a comment -

            Landed for 2.16

            pjones Peter Jones added a comment - Landed for 2.16
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49696/
            Subject: LU-16494 fileset: check fileset for operations by fid
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 9a72c073d33b0454229402c0cc930dc4e796107b

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49696/ Subject: LU-16494 fileset: check fileset for operations by fid Project: fs/lustre-release Branch: master Current Patch Set: Commit: 9a72c073d33b0454229402c0cc930dc4e796107b
            simmonsja James A Simmons added a comment -

            Site which want isolation of data sets will not use filesets if they are not totally isolated.

            simmonsja James A Simmons added a comment - Site which want isolation of data sets will not use filesets if they are not totally isolated.
            gerrit Gerrit Updater added a comment -

            "Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49802
            Subject: LU-16494 fileset: debug patch
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 7bfac333e772f0c525c8c312152e2be5da179542

            gerrit Gerrit Updater added a comment - "Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49802 Subject: LU-16494 fileset: debug patch Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 7bfac333e772f0c525c8c312152e2be5da179542
            bzzz Alex Zhuravlev added a comment -

            I'm not saying hardlinks is a problem, but I tend to think that given the filesets aren't totally isolated means that we probably don't need that check in rmfid.

            bzzz Alex Zhuravlev added a comment - I'm not saying hardlinks is a problem, but I tend to think that given the filesets aren't totally isolated means that we probably don't need that check in rmfid.
            sebastien Sebastien Buisson added a comment -

            In a subdirectory mount, you can indeed have a file that has a hard link outside of the subdirectory mount. But I can see no problem with that. And if a file inside a subdirectory mount is a soft link to a file outside of the subdirectory mount, then the link cannot be followed.

            sebastien Sebastien Buisson added a comment - In a subdirectory mount, you can indeed have a file that has a hard link outside of the subdirectory mount. But I can see no problem with that. And if a file inside a subdirectory mount is a soft link to a file outside of the subdirectory mount, then the link cannot be followed.
            bzzz Alex Zhuravlev added a comment -

            filesets aren't totally isolated, right? we can't really prevent, for example, hardlinks between filesets?

            bzzz Alex Zhuravlev added a comment - filesets aren't totally isolated, right? we can't really prevent, for example, hardlinks between filesets?
            sebastien Sebastien Buisson added a comment -

            That is indeed a drawback of this new capability. But because of DNE, this fileset check cannot be done on server side, as the full path to the subdirectory used as client fileset can be "spread" across multiple MDTs.
            Please note that in order to mitigate this drawback, the capability is disabled by default, and can be enabled per client mount point.

            sebastien Sebastien Buisson added a comment - That is indeed a drawback of this new capability. But because of DNE, this fileset check cannot be done on server side, as the full path to the subdirectory used as client fileset can be "spread" across multiple MDTs. Please note that in order to mitigate this drawback, the capability is disabled by default, and can be enabled per client mount point.
            bzzz Alex Zhuravlev added a comment -

            IMO, this kills the idea of a cheap way to remove files skipping full path traversal.

            bzzz Alex Zhuravlev added a comment - IMO, this kills the idea of a cheap way to remove files skipping full path traversal.
            gerrit Gerrit Updater added a comment -

            "Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49696
            Subject: LU-16494 fileset: check fileset for operations by fid
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 77bdcc905df478bc844444b4c5150f519bcab634

            gerrit Gerrit Updater added a comment - "Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49696 Subject: LU-16494 fileset: check fileset for operations by fid Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 77bdcc905df478bc844444b4c5150f519bcab634

            People

              sebastien Sebastien Buisson
              sebastien Sebastien Buisson
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: