Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-16549

osp_prep_update_req() packs OUT_UPDATE incorrectly

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • Lustre 2.16.0
    • Lustre 2.16.0
    • None
    • 3
    • 9223372036854775807

      lustre/osp/osp_trans.c::osp_prep_update_req()

      	req_capsule_set_size(&req->rq_pill, &RMF_OUT_UPDATE_HEADER, RCL_CLIENT,
      			     sizeof(struct osp_update_request));
      
      	req_capsule_set_size(&req->rq_pill, &RMF_OUT_UPDATE_BUF, RCL_CLIENT,
      			     buf_count * sizeof(*oub));
      

      The first struct packed is actually a struct out_update_header with no inline data, so it should be packed as a length of 16, but gets packed as length 120 because of the size of struct osp_update_request (which should NEVER go over the wire).

            vkuznetsov Vitaliy Kuznetsov
            utopiabound Nathaniel Clark
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: