[LU-16549] osp_prep_update_req() packs OUT_UPDATE incorrectly

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0
• Affects Version/s: Lustre 2.16.0
• Severity: 3
• Assignee: Vitaliy Kuznetsov
• Reporter: Nathaniel Clark

Description

lustre/osp/osp_trans.c::osp_prep_update_req()

	req_capsule_set_size(&req->rq_pill, &RMF_OUT_UPDATE_HEADER, RCL_CLIENT,
			     sizeof(struct osp_update_request));

	req_capsule_set_size(&req->rq_pill, &RMF_OUT_UPDATE_BUF, RCL_CLIENT,
			     buf_count * sizeof(*oub));

The first struct packed is actually a struct out_update_header with no inline data, so it should be packed as a length of 16, but gets packed as length 120 because of the size of struct osp_update_request (which should NEVER go over the wire).

Issue Links

• is related to: LU-16554 OUT UPDATE REPLY is always 4KiB on wire

Comments

[Peter Jones]

Landed for 2.16

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50224/
Subject: LU-16549 osp: Fix sizeof for RMF_OUT_UPDATE_HEADER
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8a10e9e03ee59e23400e375effa2f3c9041efbe2

[Gerrit Updater]

"Vitaliy Kuznetsov <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50224
Subject: LU-16549 osp: Fix sizeof for RMF_OUT_UPDATE_HEADER
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 648d059d769947a36258b5ed1eb404ef4284eac0