Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-16887

scrub does not handle OI->wrong inode situation

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.16.0
    • None
    • 3
    • 9223372036854775807

    Description

      The simple case when file is removed with ldiskfs mount leads to situation when OI exist and points to inode, but inode is reused. For such fid osd_fid_lookup() will always return EINPROGRESS. Scrub doesnot handle this problem.
      The next check compares two oi records(from inconsistent list and a fresh oi from fid) and decides that oi is fine. But unfortunately it was added to inconsistent list base on wrong inode.

        } else if (osd_id_eq(lid, lid2)) {
                     if (converted)
                             sf->sf_items_updated++;
                     GOTO(out, rc = 0);
      }
      

      Attachments

        Activity

          [LU-16887] scrub does not handle OI->wrong inode situation
          pjones Peter Jones added a comment -

          Landed for 2.16

          pjones Peter Jones added a comment - Landed for 2.16

          "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/51263/
          Subject: LU-16887 scrub: delete OI when inode missing
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: c24a090ec389ae9ca2bedb4c7e3ee777deb63c7f

          gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/51263/ Subject: LU-16887 scrub: delete OI when inode missing Project: fs/lustre-release Branch: master Current Patch Set: Commit: c24a090ec389ae9ca2bedb4c7e3ee777deb63c7f

          "Alexander Boyko <alexander.boyko@hpe.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51263
          Subject: LU-16887 scrub: delete OI when inode missing
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 36ee75b74556b61c89770e9bc26baf4e871b6fef

          gerrit Gerrit Updater added a comment - "Alexander Boyko <alexander.boyko@hpe.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51263 Subject: LU-16887 scrub: delete OI when inode missing Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 36ee75b74556b61c89770e9bc26baf4e871b6fef

          People

            aboyko Alexander Boyko
            aboyko Alexander Boyko
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: