Details

    • Task
    • Resolution: Unresolved
    • Minor
    • None
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      The data-in-dirent patch was being discussed for upstream inclusion for 64-but inode support, but eventually that was not accepted because the 64-bit inode patch was only partially tested (ie. it built and didn't break 32-bit inodes, but had code and testing gaps for actual 64-bit inode numbers).

      Landing the dirdata patch has now become more complex because the "fscrypt+case-insensitive" features are now storing extra information after the name in the dirent. This would have been a perfect case to use dirdata and get it included, except Google had already started using this in Android and didn't want to update the format, so there needs to be additional compatibility added for this case.

      An agreed-upon proposal to get dirdata accepted without the Lustre kernel dependency is to add a dedicated test ioctl interface to store dirdata in directory entries, and confirm that it is being handled properly (eg. across rename, with e2fsck, etc). For compatibility with Lustre, this could store the "inode|generation" into the Lustre FID slot, since this is equivalent to an IGIF FID, and is also easy to verify later.

      Attachments

        Issue Links

          Activity

            [LU-17423] Upstream dir_data feature

            This work is definitely not finished, only one fix patch has landed.

            adilger Andreas Dilger added a comment - This work is definitely not finished, only one fix patch has landed.
            pjones Peter Jones added a comment -

            Merged for 2.16

            pjones Peter Jones added a comment - Merged for 2.16

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/54724/
            Subject: LU-17423 ldiskfs: pass NULL to ext4_dir_rec_len for dot and dotdot
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 0c9aa07eb897c04e5eeb563bf757745da16a05a4

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/54724/ Subject: LU-17423 ldiskfs: pass NULL to ext4_dir_rec_len for dot and dotdot Project: fs/lustre-release Branch: master Current Patch Set: Commit: 0c9aa07eb897c04e5eeb563bf757745da16a05a4

            "Li Dongyang <dongyangli@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54724
            Subject: LU-17423 ldiskfs: pass NULL to ext4_dir_rec_len for dot and dotdot
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 8348ef6cac5df4d91c6ed8c65a9e42857855f32e

            gerrit Gerrit Updater added a comment - "Li Dongyang <dongyangli@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54724 Subject: LU-17423 ldiskfs: pass NULL to ext4_dir_rec_len for dot and dotdot Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 8348ef6cac5df4d91c6ed8c65a9e42857855f32e

            People

              dongyang Dongyang Li
              adilger Andreas Dilger
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated: