Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6220

push ext4/ldiskfs patches upstream if possible

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: Lustre 2.8.0
    • Fix Version/s: Upstream
    • Labels:
      None
    • Rank (Obsolete):
      17396

      Description

      There are a number of ldiskfs patches that we could potentially push upstream, possibly with some cleanups. All patches should be run through checkpatch.pl first.

      • ext4-print-inum-in-htree-warning.patch: could be pushed upstream after moving string to the next line so it fits inside 80 columns
      • ext4-disable-mb-cache.patch: I was involved in some discussion upstream about removing the mbcache (http://lwn.net/Articles/564802/), but that patch was never accepted upstream. We could try pushing this patch again, since it is fairly simple, and it wouldn't be very incompatible with the other mbcache speedup patch if that was ever landed.
      • ext4-inode-version.patch: It might be possible to submit a patch upstream that moves dir->i_version++ into ext4_mark_iloc_dirty() like if (IS_I_VERSION(inode) || S_ISDIR(dir)). Then, we can add a mount flag or patch that makes this check a no-op so we only need a very small patch. More importantly, it will reduce the size of ext4_inode_info because we don't need a separate i_fs_version and reduce the memory usage on the MDS.
      • ext4-journal-path-opt.patch: I think this can be pushed upstream without any significant changes
      • ext4-kill-dx-root.patch: could be submitted upstream as a cleanup with some style fixes
      • ext4-max-dir-size.patch: we should print out a deprecation warning in newer kernels to mount with "-o max_dir_size_kb" instead, and then we can eventually remove it? The mount option has existed since kernel 3.6, maybe it would be better to backport support for the mount option to RHEL6 instead of maintaining this patch forever?
      • ext4-large-eas.patch: this is described in LU-908

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ys Yang Sheng
                Reporter:
                adilger Andreas Dilger
              • Votes:
                1 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated: