[LU-1855] Coverity: Fix 'out-of-bounds access' errors

• Type: Technical task
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.4.0
• Affects Version/s: Lustre 2.4.0, Lustre 2.1.3
• Labels: build coverity
• Assignee: Minh Diep
• Reporter: Sebastien Buisson (Inactive)

Description

Thanks to the Coverity tool, we found some memory corruptions in the Lustre code, and more specifically cases of out-of-bounds access in functions sec_flags2str() and sptlrpc_secflags2str().
These functions take as arguments a buffer (2nd) and its size (3rd), that will be used by strncat(). Given that strncat() always adds a trailing '\0', the size passed to it must be 'bufsize-1'.

I will propose a patch to address this problem.

Sebastien.

Issue Links

• is related to: LU-17000 Coverity static analysis issues

Comments

[Minh Diep]

landed on master

[Minh Diep]

sure

[Peter Jones]

Thanks for the patch Sebastien. Minh can you please take care of landing this patch?

[Sebastien Buisson (Inactive)]

The patch is available here:
http://review.whamcloud.com/3902

Could you please review it?