[LU-17000] Coverity static analysis issues

• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Labels: easy
• Severity: 3
• Assignee: Tim Day
• Reporter: Tim Day

Description

I've been experimenting with more static analyzers (Coverity in this case). While it does have some false positives, it looks like it found a number of legitimate bugs. See https://scan.coverity.com/projects/lustre for details.

It's seems like Coverity has been used with Lustre in the past (see: https://wiki.lustre.org/images/8/8a/LUG2013-Lustre_Static_Code_Analysis-Bull.pdf). Although, it doesn't seem like it's been run in a while.

Also, there's a number of Coverity comments that seem out-dated and should probably just be cleaned up.

Issue Links

• is related to: LU-18560 ldiskfs_write_ldd(): Coverity reports issues
• is related to: LU-2753 Tracking bug for static code analysis fixes.
• is related to: LU-1855 Coverity: Fix 'out-of-bounds access' errors
• is related to: LU-1856 Coverity: Fix 'Out-of-bounds write' errors
• is related to: LU-1884 Coverity: Fix 'resource leak' errors
• is related to: LU-1857 Coverity: Fix 'Unbounded source buffer' errors
• is related to: LU-1889 Fix false 'uninitialized scalar variable' errors found by Coverity
• is related to: LU-1907 Remove function resolution mistakes made by Coverity
• is related to: LU-2709 Coverity: Fix 'memory corruption' errors
• is related to: LU-2710 Remove function resolution mistakes made by Coverity