[LU-17000] Coverity static analysis issues

• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Labels: easy
• Severity: 3
• Assignee: Tim Day
• Reporter: Tim Day

Description

I've been experimenting with more static analyzers (Coverity in this case). While it does have some false positives, it looks like it found a number of legitimate bugs. See https://scan.coverity.com/projects/lustre for details.

It's seems like Coverity has been used with Lustre in the past (see: https://wiki.lustre.org/images/8/8a/LUG2013-Lustre_Static_Code_Analysis-Bull.pdf). Although, it doesn't seem like it's been run in a while.

Also, there's a number of Coverity comments that seem out-dated and should probably just be cleaned up.

Issue Links

• is related to: LU-18560 ldiskfs_write_ldd(): Coverity reports issues
• is related to: LU-18608 Insecure data handling (INTEGER_OVERFLOW) /lustre/llite/pcc.c: pcc_io_fini() in pcc_file_read_iter()
• is related to: LU-2753 Tracking bug for static code analysis fixes.
• is related to: LU-1855 Coverity: Fix 'out-of-bounds access' errors
• is related to: LU-1856 Coverity: Fix 'Out-of-bounds write' errors
• is related to: LU-1884 Coverity: Fix 'resource leak' errors
• is related to: LU-1857 Coverity: Fix 'Unbounded source buffer' errors
• is related to: LU-1889 Fix false 'uninitialized scalar variable' errors found by Coverity
• is related to: LU-1907 Remove function resolution mistakes made by Coverity
• is related to: LU-2709 Coverity: Fix 'memory corruption' errors
• is related to: LU-2710 Remove function resolution mistakes made by Coverity

Comments

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/59499
Subject: LU-17000 obdclass: Fix mem leak in lcfg_setparam_client
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 477bebf6053a98a6cc24a1c40893c4625ea8e626

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/59477
Subject: LU-17000 obdclass: Fix mem leak in pool_add_objects
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0b773cb1e85e583843ad2906cacf37aef798b8ba

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/59456
Subject: LU-17000 llite: Handle not NUL buffer in ll_statahead_info
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3088783b720f54ec4c03b18ab91e0908a8e71ac2

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/55377/
Subject: LU-17000 llite: Handle not NUL terminated buffer
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 517e76cbefe800251d6d132c7f1d8a0d965d089e

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/58360/
Subject: LU-17000 mgs: check lcfg parameters
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5e4456e9dfeb9ef513ed26eb06ce9251888c991d

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/58362/
Subject: LU-17000 misc: avoid memory leaks in error handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f641b364c200762eb35e78607efb6d4dbbf9906f

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/58361/
Subject: LU-17000 llite: fix memory leaks in error handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 39a4e71c532b3f0180ef59bc8cb78aa21b85256f

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58362
Subject: LU-17000 misc: avoid memory leaks in error handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c5ad634d4c5101d96f476dd3f59f4a84d838a4af

[Gerrit Updater]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58361
Subject: LU-17000 llite: fix memory leaks in error handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fc5ba05ddc5b4a2320efe2babc20589e435e677a

[Andreas Dilger]

"Andreas Dilger <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58360
Subject: LU-17000 mgs: check lcfg parameters
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5a0f6a7388e16f12d7873e274547bc47b1d7175e