Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-18796

Fix Coverity issues introduced by "LU-13717 sec: filename encryption - digest support"

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • Lustre 2.17.0
    • 3
    • 9223372036854775807

    Description

      *** CID 457073:  Resource leaks  (RESOURCE_LEAK)
      /lustre/llite/crypto.c: 571 in ll_fname_disk_to_usr()
      565     			/* Without the key for long names, set the dentry name
      566     			 * to the representing struct ll_digest_filename. It
      567     			 * will be encoded by llcrypt for display, and will
      568     			 * enable further lookup requests.
      569     			 */
      570     			if (!fid)
         CID 457073:  Resource leaks  (RESOURCE_LEAK)
         Variable "lltr" going out of scope leaks the storage "lltr.name" points to.
      571     				return -EINVAL;
      572     			digest.ldf_fid = *fid;
      573     			memcpy(digest.ldf_excerpt,
      574     			       LLCRYPT_EXTRACT_DIGEST(lltr.name, lltr.len),
      575     			       sizeof(digest.ldf_excerpt));
      576     
      

      Attachments

        Activity

          [LU-18796] Fix Coverity issues introduced by "LU-13717 sec: filename encryption - digest support"

          "Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58372
          Subject: LU-18796 llite: fix coverity issue in ll_fname_disk_to_usr
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 2324987af8c6a61c4e3f5b64623ccecc40d459bc

          gerrit Gerrit Updater added a comment - "Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/58372 Subject: LU-18796 llite: fix coverity issue in ll_fname_disk_to_usr Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 2324987af8c6a61c4e3f5b64623ccecc40d459bc

          People

            sebastien Sebastien Buisson
            sebastien Sebastien Buisson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: