Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-2753 Tracking bug for static code analysis fixes.
  3. LU-1884

Coverity: Fix 'resource leak' errors

Details

    • 4437

    Description

      Thanks to the Coverity tool, we found some resource leak errors in the Lustre code. This is typically what happens when a function forgets to free some allocated memory or close some file descriptor while returning in case of error.

      I will propose a patch to address the issues.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-2644 Fix 'resource leak' errors

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LU-17000 Coverity static analysis issues

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            [LU-1884] Coverity: Fix 'resource leak' errors
            sebastien.buisson Sebastien Buisson (Inactive) added a comment -

            By opening a new ticket, I was afraid that all changes related to this 'resource leak' thing were spread among various tickets, hence making it difficult to track.

            sebastien.buisson Sebastien Buisson (Inactive) added a comment - By opening a new ticket, I was afraid that all changes related to this 'resource leak' thing were spread among various tickets, hence making it difficult to track.
            pjones Peter Jones added a comment -

            Rather than reopen this ticket it would be better to open a new ticket to track the changes needed in more recent code.

            pjones Peter Jones added a comment - Rather than reopen this ticket it would be better to open a new ticket to track the changes needed in more recent code.
            sebastien.buisson Sebastien Buisson (Inactive) added a comment -

            I have posted a new patch:
            http://review.whamcloud.com/5128

            TIA,
            Sebastien.

            sebastien.buisson Sebastien Buisson (Inactive) added a comment - I have posted a new patch: http://review.whamcloud.com/5128 TIA, Sebastien.
            sebastien.buisson Sebastien Buisson (Inactive) added a comment -

            Hi,
            I would like to reopen this ticket, as Coverity has found new 'resource leak' errors in more recent code (2.3.58).

            sebastien.buisson Sebastien Buisson (Inactive) added a comment - Hi, I would like to reopen this ticket, as Coverity has found new 'resource leak' errors in more recent code (2.3.58).
            jlevi Jodi Levi (Inactive) added a comment -

            Please let me know if this ticket needs to be reopened.

            jlevi Jodi Levi (Inactive) added a comment - Please let me know if this ticket needs to be reopened.
            pjones Peter Jones added a comment -

            Thanks Sebastien. Bob, another one to take care of - thanks!

            pjones Peter Jones added a comment - Thanks Sebastien. Bob, another one to take care of - thanks!
            sebastien.buisson Sebastien Buisson (Inactive) added a comment -

            The patch is available here:

            http://review.whamcloud.com/3934

            Could you please review it?

            sebastien.buisson Sebastien Buisson (Inactive) added a comment - The patch is available here: http://review.whamcloud.com/3934 Could you please review it?

            People

              bogl Bob Glossman (Inactive)
              sebastien.buisson Sebastien Buisson (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: