[LU-18997] lnet_sock_create may return NULL on error

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Fix Version/s: Lustre 2.17.0
• Affects Version/s: Lustre 2.17.0
• Labels: smatch
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

smatch highlighter that lnet_sock_create() has a path that tries to return ERR_PTR(0) which is NULL, that would break the callers expecting PTR_ERR:

                         if (interface >= 0 && remaddr) {
                                struct sockaddr_in6 *rem = (void *)remaddr;
                                struct net_device *dev;                                rcu_read_lock();
                                dev = dev_get_by_index_rcu(ns, interface);
                                if (!dev) {
                                        CERROR("No net device for interface %d\n",
                                               interface);
                                        rcu_read_unlock();
                                        goto failed;
                                }

...
failed:
        sock_release(sock);
        return ERR_PTR(rc);
}

Introduced by https://review.whamcloud.com/c/fs/lustre-release/+/55582

Issue Links

• is related to: LU-17460 sanity-lnet test_214 causes a netdevice reference leak with IPv6