[LU-2049] add support for OBD_CONNECT_GRANT_PARAM

• Type: Technical task
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.10.0
• Affects Version/s: Lustre 2.4.0, Lustre 2.5.0
• Labels: HB llnl prz
• Assignee: Nathaniel Clark
• Reporter: Johann Lombardi (Inactive)

Description

Currently, grant is still inflated if backend block size > page size (that's the case with zfs osd).
OBD_CONNECT_GRANT_PARAM was added to address this and we need to develop the the code in osc & ofd to implement support for this feature.

Issue Links

• is blocking: LU-3522 sanity-benchmark test_iozone: "no space left on device" on ZFS
• is duplicated by: LU-7970 intermittent ENOSPC on osd_write_commit
• is duplicated by: LU-1507 Fix confusing code in obd_connect_data
• is related to: LU-8007 Kernel: LustreError: 191208:0:(vvp_io.c:1086:vvp_io_commit_write()) Write page 82782 of inode ffff8803a8fd06b8 failed -28
• is related to: LU-7510 (vvp_io.c:1088:vvp_io_commit_write()) Write page 962977 of inode ffff880fbea44b78 failed -28
• is related to: LU-7803 sanity test 78 failures in interop

Comments

[Nathaniel Clark]

It looks like everything has landed for this, can this bug be resolved?

[Oleg Drokin]

I filed LU-7803 for a potential interop issue that I am experiencing now.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/7793/
Subject: LU-2049 grant: add support for OBD_CONNECT_GRANT_PARAM
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: bd1e41672c974b97148b65115185a57ca4b7bbde

[Andreas Dilger]

The main goal of this patch is to reduce the grant over-provisioning for clients that do not understand large blocks on ZFS. It would be useful to run a manual test, or better to write a sanity subtest that compares the grant on the client with the grant on the server to ensure they roughly match rather than being inflated by a factor of (128/4).

For ZFS OSTs the test should be skipped if this feature is not available on the OSC file:

        [ "$(facet_fstype ost1)" = "ZFS" ] && $LCTL get_param osc.$FSNAME-OST0000*.import |
                grep -q "connect_flags:.*grant_param" ||
                { skip "grant_param not available" && return }

[Andreas Dilger]

Patch http://review.whamcloud.com/7793 needs to be refreshed and landed.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13531/
Subject: LU-2049 grant: delay grant releasing until commit
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 31b7404f436241436fb0abdec2b6cd678c674d82

[Andreas Dilger]

Jinshan, are you able to refresh this patch?

[Jinshan Xiong (Inactive)]

I will work on this.

[Gerrit Updater]

Johann Lombardi ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13531
Subject: LU-2049 grant: delay grant releasing until commit
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: edcd417f753864279a439ef8e80eff100fde3f72

[Sarah Liu]

Here is the for test only patch of patched server with unpatched client:
http://review.whamcloud.com/#/c/12404/

[Sarah Liu]

Here is the result for unpatched server(ldiskfs) and patched client, with sanity test_64b and sanityn test_15 enabled:
I will change the test parameters and test other configurations and keep you updated.

https://testing.hpdd.intel.com/test_sessions/ec4adf00-58eb-11e4-9a9c-5254006e85c2

result for unpatched server(zfs) and patched client:
https://testing.hpdd.intel.com/test_sessions/eba4dd82-59d4-11e4-8dbb-5254006e85c2