[LU-2049] add support for OBD_CONNECT_GRANT_PARAM

• Type: Technical task
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.10.0
• Affects Version/s: Lustre 2.4.0, Lustre 2.5.0
• Labels: HB llnl prz
• Assignee: Nathaniel Clark
• Reporter: Johann Lombardi (Inactive)

Description

Currently, grant is still inflated if backend block size > page size (that's the case with zfs osd).
OBD_CONNECT_GRANT_PARAM was added to address this and we need to develop the the code in osc & ofd to implement support for this feature.

Issue Links

• is blocking: LU-3522 sanity-benchmark test_iozone: "no space left on device" on ZFS
• is duplicated by: LU-7970 intermittent ENOSPC on osd_write_commit
• is duplicated by: LU-1507 Fix confusing code in obd_connect_data
• is related to: LU-8007 Kernel: LustreError: 191208:0:(vvp_io.c:1086:vvp_io_commit_write()) Write page 82782 of inode ffff8803a8fd06b8 failed -28
• is related to: LU-7510 (vvp_io.c:1088:vvp_io_commit_write()) Write page 962977 of inode ffff880fbea44b78 failed -28
• is related to: LU-7803 sanity test 78 failures in interop

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/25853/
Subject: LU-2049 grant: Fix grant interop with pre-GRANT_PARAM clients
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 03f24e6f786459b3dd8a37ced7fb3842b864613d

[Gerrit Updater]

Nathaniel Clark ([e-mail]) uploaded a new patch: https://review.whamcloud.com/25853
Subject: LU-2049 grant: Fix grant interop with pre-GRANT_PARAM clients
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 15044478ce5f96a6bc80d8209e7fa9fed3f1a8a0

[Nathaniel Clark]

After enabling grant checking:
https://testing.hpdd.intel.com/test_sets/275100e8-5ff2-11e6-b5b1-5254006e85c2

All the tests that were checked failed.

[Gerrit Updater]

Nathaniel Clark ([e-mail]) uploaded a new patch: http://review.whamcloud.com/21619
Subject: LU-2049 tests: FOR TEST ONLY GRANT_CHECK
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 64d3edb56be5b8af451a7b6947aad623fccf01ca

[Cameron Harr]

We started hitting the symptoms of LU-7510 the last couple week or so, for which this patch is marked as a fix. We're running a 2.5-5 branch. Of our 80 OSTs, we had 32 that were ~90% full and the rest were closer to 65% full. Deactivating those fuller OSTs appears to have worked around the issue for now, though we think it's starting to happen on a sister file system.

[Andreas Dilger]

It doesn't appear that there was a test in the last patch to verify that the new grant code is working properly. I haven't looked in detail whether it is practical to make a test or not, but that should at least be given a few minutes attention before closing the bug.

[Nathaniel Clark]

It looks like everything has landed for this, can this bug be resolved?

[Oleg Drokin]

I filed LU-7803 for a potential interop issue that I am experiencing now.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/7793/
Subject: LU-2049 grant: add support for OBD_CONNECT_GRANT_PARAM
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: bd1e41672c974b97148b65115185a57ca4b7bbde

[Andreas Dilger]

The main goal of this patch is to reduce the grant over-provisioning for clients that do not understand large blocks on ZFS. It would be useful to run a manual test, or better to write a sanity subtest that compares the grant on the client with the grant on the server to ensure they roughly match rather than being inflated by a factor of (128/4).

For ZFS OSTs the test should be skipped if this feature is not available on the OSC file:

        [ "$(facet_fstype ost1)" = "ZFS" ] && $LCTL get_param osc.$FSNAME-OST0000*.import |
                grep -q "connect_flags:.*grant_param" ||
                { skip "grant_param not available" && return }

[Andreas Dilger]

Patch http://review.whamcloud.com/7793 needs to be refreshed and landed.