Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-225

--with-ldiskfs-inkernel checks wrong file

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.1.0
    • Lustre 2.0.0, Lustre 2.1.0
    • None
    • 3
    • 5042

    Description

      Commit fd0bd149e66cbc06a17c372e159f9bfba024cc97 changed which file is checked
      to verify a correct ldiskfs installation when the --with-ldiskfs-inkernel
      configure option is used:

      diff --git a/build/autoconf/lustre-build.m4 b/build/autoconf/lustre-build.m4
      index c70afbf..0d9d029 100644
      --- a/build/autoconf/lustre-build.m4
      +++ b/build/autoconf/lustre-build.m4
      ...
      @@ -221,13 +301,13 @@ case x$with_ldiskfs in
                      ;;
              xinkernel)
                      AC_MSG_RESULT([inkernel])
      -               LB_CHECK_FILE([$LINUX/include/linux/ldiskfs_fs.h],[],[
      -                       AC_MSG_ERROR([ldiskfs was not found in $LINUX/include/linux/ldiskfs_fs.h])
      +               LB_CHECK_FILE([$LINUX/fs/ldiskfs/inode.c],[],[
      +                       AC_MSG_ERROR([ldiskfs was not found in $LINUX/fs/ldiskfs/inode.c])
                      ])
                      ;;
              *)
                      AC_MSG_RESULT([$with_ldiskfs])
      -               LB_CHECK_FILE([$with_ldiskfs/ldiskfs/linux/ldiskfs_fs.h],[],[
      +               LB_CHECK_FILE([$with_ldiskfs/ldiskfs/inode.c],[],[
                              AC_MSG_ERROR([A complete (built) external ldiskfs was not found.])
                      ])
                      LDISKFS_DIR=$with_ldiskfs
      
      

      It looks like the person fixing the *) case assumed the same fix applied to xinkernel).
      However, this is wrong because the purpose of --with-ldiskfs-inkernel is to allow us to
      build lustre without having full kernel sources available, so inode.c won't exist. I'll
      push a fix to gerrit.

      Attachments

        Activity

          People

            laisiyao Lai Siyao
            nedbass Ned Bass (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: