Details

    • 6713

    Description

      There is an 8 byte write only field and some separated flag bits that trigger another 8 bytes of extra alignment padding that are not necessary. There are also a couple of fields that are only used on the server side and others only used on the client side. These fields could be overlaid, with 24 bytes easily saved. This is important on systems where 100's of thousands of these structures get allocated.

      My first comment will show one approach for coalescing all the flag bits into a single 64 bit flag word.

      Attachments

        Activity

          [LU-2771] Wasted space in ldlm_lock structure
          pjones Peter Jones made changes -
          Fix Version/s New: Lustre 2.16.0 [ 15190 ]
          jlevi Jodi Levi (Inactive) made changes -
          Fix Version/s New: Lustre 2.5.0 [ 10295 ]
          keith Keith Mannthey (Inactive) made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          keith Keith Mannthey (Inactive) made changes -
          Assignee Original: WC Triage [ wc-triage ] New: Keith Mannthey [ keith ]
          pjones Peter Jones made changes -
          Labels Original: locking New: locking patch
          bkorb Bruce Korb (Inactive) made changes -
          Attachment New: l_flags.h [ 12241 ]
          bkorb Bruce Korb (Inactive) created issue -

          People

            keith Keith Mannthey (Inactive)
            bkorb Bruce Korb (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: