Details
-
Bug
-
Resolution: Fixed
-
Minor
-
None
-
3
-
6945
Description
If we use ONLY variable, then the test-framework generates garbage in its output, that complicates log parsing, because of randomness behavior. For example, following command:
ONLY=6h /usr/lib64/lustre/tests/sanity.sh
can have following output:
ONLY=6h /usr/lib64/lustre/tests/sanity.sh Logging to shared log directory: /testing/aaaa/test_logs/1361270584 itm76.xyua: Checking config lustre mounted on /mnt/lustre Checking servers environments Checking clients itm76.xyua environments Using TIMEOUT=20 disable quota as required setting all flavor to null already have total 5 null connections running as uid/gid/euid/egid 500/500/500/500, groups: [touch] [/mnt/lustre/d0_runas_test/f32541] only running test 6h excepting tests: 27u 42a 42b 42c 42d 45 51d 68b skipping tests SLOW=no: 24o 24v 27m 36f 36g 36h 51b 60c 63 64b 68 71 73 77f 78 101a 103 115 120g 124b preparing for tests involving mounts mke2fs 1.42.6.x1 (10-Dec-2012) debug=-1 .................... == sanity test 6h: runas -u 500 -g 500 chown RUNAS_ID.0 .../f6h (should return error) == 12:43:05 (1361270585) running as uid/gid/euid/egid 500/500/500/500, groups: 500 [chown] [500:0] [/mnt/lustre/f6h] chown: changing ownership of `/mnt/lustre/f6h': Operation not permitted /mnt/lustre/f6h has type file OK /mnt/lustre/f6h is owned by user #500 OK /mnt/lustre/f6h is owned by group #500 OK Resetting fail_loc on all nodes...done. PASS 6h (0s) ................................................................................................................................................................................................................................................................................................................resend_count is set to 4 4 4 4 ...........resend_count is set to 10 10 10 10 ......................................................................................== sanity sanity.sh test complete, duration 2 sec == 12:43:06 (1361270586) debug=super ioctl neterror warning dlmtrace error emerg ha rpctrace vfstrace config console
Where numerous dots ..... are generated garbage by run_test function, see 3285 line of test-framework.sh exerpt:
3267 run_test() {
3268 assert_DIR
3269
3270 export base=`basetest $1`
3271 if [ ! -z "$ONLY" ]; then
3272 testname=ONLY_$1
3273 if [ ${!testname}x != x ]; then
3274 [ "$LAST_SKIPPED" ] && echo "" && LAST_SKIPPED=
3275 run_one_logged $1 "$2"
3276 return $?
3277 fi
3278 testname=ONLY_$base
3279 if [ ${!testname}x != x ]; then
3280 [ "$LAST_SKIPPED" ] && echo "" && LAST_SKIPPED=
3281 run_one_logged $1 "$2"
3282 return $?
3283 fi
3284 LAST_SKIPPED="y"
3285 echo -n "."
3286 return 0
3287 fi
3288
The reason is in this line:
3285 echo -n "."