[LU-3161] LASSERT() in lod_initialize_objects()

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.6.0, Lustre 2.4.2, Lustre 2.5.1
• Affects Version/s: Lustre 2.4.0
• Labels: patch
• Severity: 3
• Assignee: Zhenyu Xu
• Reporter: Andreas Dilger

Description

Looking at the code in lod_initialize_objects() I found the following comment and code:

                /*
                 * XXX: assertion is left for testing, to make
                 * sure we never process requests till configuration
                 * is completed. to be changed to -EINVAL
                 */

                lod_getref(&md->lod_ost_descs);
                LASSERT(cfs_bitmap_check(md->lod_ost_bitmap, idx));
                LASSERT(OST_TGT(md,idx));
                LASSERTF(OST_TGT(md,idx)->ltd_ost, "idx %d\n", idx);

This should be replaced by proper error handling, in case of LOV EA corruption on disk, or OST removal.

Issue Links

• is related to: LU-3917 lod_initialize_objects()) ASSERTION( cfs_bitmap_check(md->lod_ost_descs.ltd_tgt_bitmap, idx) ) failed
• is related to: LU-3918 kernel NULL pointer dereference at lod_initialize_objects+0x327

Comments

[Zhenyu Xu]

b2_5 port at http://review.whamcloud.com/8598

[Peter Jones]

Landed for 2.6

[Gaurav Mahajan (Inactive)]

Gerrit patch: http://review.whamcloud.com/#/c/7234/