[LU-3470] incompatbile error handling in llog_open()

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.4.1, Lustre 2.5.0
• Affects Version/s: Lustre 1.8.9, Lustre 2.4.1, Lustre 2.5.0
• Labels: mn8 patch
• Severity: 3
• Assignee: Bobbie Lind (Inactive)
• Reporter: Li Xi (Inactive)

Description

In master version, llog_open() calls llog_alloc_handle() bug does not handle return value correctly. It takes NULL as the error return value. But llog_alloc_handle() returns ERR_PTR(-ENOMEM) instead when error.

This is also an problem in llog_client_create() in Lustre-1.8.9. This problem is related to LU-980.

Comments

[Bobbie Lind (Inactive)]

Patch has landed to master.

[Bobbie Lind (Inactive)]

The patch was successfully cherry-picked to master. I have ported the patch to b1_8 and it is tracked at http://review.whamcloud.com/#/c/7106/

[Bobbie Lind (Inactive)]

This patch failed due to the recently fixed LU-3453 LBUG. I will rebase and resubmit.

[Peter Jones]

Thanks Li Xi.

Bobbie

Could you please take care of this patch?

Thanks

Peter

[Li Xi (Inactive)]

the patch is tracked at http://review.whamcloud.com/#change,6644