[LU-3494] Libcfs binary heap improvements

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.5.0
• Affects Version/s: Lustre 2.5.0
• Labels: patch
• Assignee: Bobbie Lind (Inactive)
• Reporter: Li Xi (Inactive)

Description

Binary heap in libcfs enables NRS policies to sort requests efficiently. But the API of it is not sufficient enough for some use cases.

For example, if we want to change the values of the node in the heap, we have to remove the node from the heap, change the values and then insert the node into the heap again. However, the process of inserting into the heap might fails because of memory insufficiency. Sometimes, it is not convienient and efficient for a caller to handle such kind of failure which can be easily avioded by adding new APIs

What's more, there is no API for a caller to judge whether a node is in the heap or not, which is not convienient too.

Comments

[Bobbie Lind (Inactive)]

Patch cherry-picked for master as 8beee9d0ff74f78fc5b072d1cf98f55d927dcdbe

[Peter Jones]

Bobbie

Could you please take care of this one?

Thanks

Peter

[Peter Jones]

Thanks for the patch Li Xi

[Li Xi (Inactive)]

This patch adds a funtion which relocates the changed node in a heap.
http://review.whamcloud.com/#/c/6743/