[LU-3517] ll_lookup_it() checks for O_CREAT in it_create_mode

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.5.0
• Affects Version/s: Lustre 2.5.0
• Labels: llite
• Severity: 3
• Assignee: John Hammond
• Reporter: John Hammond

Description

ll_lookup_it() checks for O_CREAT in it_create_mode which is nonsensical, as it_flags is used for open flags (O_RDWR, O_CREAT, ...), while it_create_mode is used for file mode bits (S_IFREG, S_IRUSR, ...):

        if (it->it_op & IT_CREAT ||
            (it->it_op & IT_OPEN && it->it_create_mode & O_CREAT))
		opc = LUSTRE_OPC_CREATE;
        else
                opc = LUSTRE_OPC_ANY;

The same is true of llu_lookup_it().