Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-3568

Leading comments should be stripped from commit messages

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.5.0
    • Lustre 2.1.6
    • 0.1
    • 8979

    Description

      Sometimes, git likes to insert "git status" commentary at the top of an auto-generated commit message starter file. If the committer carelessly neglects to remove the stuff, the script thinks the message has a missing commit summary line. The fix is trivial.

      Attachments

        Activity

          [LU-3568] Leading comments should be stripped from commit messages
          keith Keith Mannthey (Inactive) added a comment -

          Patch for Master has been landed.

          keith Keith Mannthey (Inactive) added a comment - Patch for Master has been landed.
          keith Keith Mannthey (Inactive) added a comment -

          These changes have been committed to Master.

          Is it intended to push these changes to other branches?

          keith Keith Mannthey (Inactive) added a comment - These changes have been committed to Master. Is it intended to push these changes to other branches?
          pjones Peter Jones added a comment -

          Keith

          Could you please take care of this one?

          Thanks

          Peter

          pjones Peter Jones added a comment - Keith Could you please take care of this one? Thanks Peter
          bkorb Bruce Korb (Inactive) added a comment -

          Tabification has now been pushed. The real patch is now built upon this.

          bkorb Bruce Korb (Inactive) added a comment - Tabification has now been pushed. The real patch is now built upon this.
          bkorb Bruce Korb (Inactive) added a comment - - edited

          http://review.whamcloud.com/6928 == tabify commit-msg script
          http://review.whamcloud.com/6921 == actual patch
          Xyratex-bug-id: MRP-1160

          bkorb Bruce Korb (Inactive) added a comment - - edited http://review.whamcloud.com/6928 == tabify commit-msg script http://review.whamcloud.com/6921 == actual patch Xyratex-bug-id: MRP-1160
          bkorb Bruce Korb (Inactive) added a comment -

          Cheng suggested an alternative "9998-current.patch"

          bkorb Bruce Korb (Inactive) added a comment - Cheng suggested an alternative "9998-current.patch"

          People

            keith Keith Mannthey (Inactive)
            bkorb Bruce Korb (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: