Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-3597

packet-lustre.c opcodes out of sync with lustre_idl.h

Details

    • 3
    • 9121

    Description

      On v2_4_52_0-2-g809d46b, the last MDS opcode in lustre_idl.h is MDS_SWAP_LAYOUTS = 61 (added by 4af3ab19), while the last MDS opcode in packet-lustre.c is MDS_GET_INFO = 53. What is the mechanism for keeping these files in sync?

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-1606 lustre_idl.h does not compile in user-space

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            [LU-3597] packet-lustre.c opcodes out of sync with lustre_idl.h
            jlevi Jodi Levi (Inactive) added a comment -

            Patch landed to Master. If more work is needed in this ticket please let me know and I will reopen or create new ticket for follow on work.

            jlevi Jodi Levi (Inactive) added a comment - Patch landed to Master. If more work is needed in this ticket please let me know and I will reopen or create new ticket for follow on work.
            utopiabound Nathaniel Clark added a comment -

            Here's just a basic update of MDS opcodes:
            http://review.whamcloud.com/7005

            utopiabound Nathaniel Clark added a comment - Here's just a basic update of MDS opcodes: http://review.whamcloud.com/7005
            utopiabound Nathaniel Clark added a comment -

            Using lustre_idl.h may be more complicated due to LU-1606.

            utopiabound Nathaniel Clark added a comment - Using lustre_idl.h may be more complicated due to LU-1606 .
            utopiabound Nathaniel Clark added a comment -

            It seems reasonable to have the wireshark plugin require lustre-devel (which is actually lustre-client) to build.

            utopiabound Nathaniel Clark added a comment - It seems reasonable to have the wireshark plugin require lustre-devel (which is actually lustre-client) to build.
            doug Doug Oucharek (Inactive) added a comment -

            The original thinking in the Wireshark support was we will want to push the Lustre support plugins upstream. As such we tried to make the contrib/wireshark directory self-contained and not dependent on any Lustre files. That makes keeping the opcodes in sync an manual process (as they will be when this is upstream).

            However, we are not sure when we will be working to push these upstream so creating a "temporary" dependancy on lustre_idl.h would probably be ok.

            doug Doug Oucharek (Inactive) added a comment - The original thinking in the Wireshark support was we will want to push the Lustre support plugins upstream. As such we tried to make the contrib/wireshark directory self-contained and not dependent on any Lustre files. That makes keeping the opcodes in sync an manual process (as they will be when this is upstream). However, we are not sure when we will be working to push these upstream so creating a "temporary" dependancy on lustre_idl.h would probably be ok.

            People

              utopiabound Nathaniel Clark
              jhammond John Hammond
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: