[LU-3709] Coordinator follow-on patche: code cleaning

• Type: Technical task
• Resolution: Fixed
• Priority: Blocker
• Fix Version/s: Lustre 2.5.0
• Affects Version/s: Lustre 2.5.0
• Labels: HSM
• Assignee: Jinshan Xiong (Inactive)
• Reporter: CEA

Description

When the cdt main thread will be landing some cross-component code cleaning needs to be done:

• replace hai_zero() by hai_first()
• display policy in /proc must be: policy1 [policy2] policy3
• replace use of cfs_list_XXX by kernel functions, avoid use of list_entry() in list_XXX loop
• remove extra parenthesis in if tests in HSM mdt files
• "find" functions like mdt_hsm_get_md_hsm() or cdt_find_request_nolock() must return NULL if not found in place of ERR_PTR(-ENOENT)
• clean 2 err msg in mdt_hsm_cdt_agent.c
• styles in lmv_obd.c (from LU-3365)
• err code printed 2 times in mdt_hsm_cdt_agent.c

It will be safer to wait for sanity-hsm landing before landing these patches so maloo will validate them on the full HSM stack

I will prepare the patch

Comments

[jacques-charles lafoucriere]

The remaining item "display policy in /proc must be: policy1 [policy2] policy3" is in ticket LU-3756

[jacques-charles lafoucriere]

Patch are:
MDT part http://review.whamcloud.com/7254 (depends on CDT)
LMV part http://review.whamcloud.com/7252 (no dependency)

Missing is new policy display under /proc. Will do another patch for it.