[LU-4067] bad error return from osd_object_create()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.6.0, Lustre 2.5.1
• Affects Version/s: Lustre 2.5.0
• Labels: coccinelle zfs
• Severity: 3
• Assignee: John Hammond
• Reporter: John Hammond

Description

An error path in the ZFS osd_object_create() applies PTR_ERR() to the valid thandle pointer:

        db = osd_create_type_f(dof->dof_type)(env, osd, attr, zapid, oh);
        if (IS_ERR(db))
                GOTO(out, rc = PTR_ERR(th));

Surely PTR_ERR(db) should be used instead. This was found using one of the coccinelle example scripts.

Also 'Quota' is misspelled in a comment.

Issue Links

• is related to: LU-2753 Tracking bug for static code analysis fixes.