Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-4067

bad error return from osd_object_create()

Details

    • 3
    • 10901

    Description

      An error path in the ZFS osd_object_create() applies PTR_ERR() to the valid thandle pointer:

              db = osd_create_type_f(dof->dof_type)(env, osd, attr, zapid, oh);
        if (IS_ERR(db))
                GOTO(out, rc = PTR_ERR(th));

      Surely PTR_ERR(db) should be used instead. This was found using one of the coccinelle example scripts.

      Also 'Quota' is misspelled in a comment.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-2753 Tracking bug for static code analysis fixes.

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Resolved

          Activity

            [LU-4067] bad error return from osd_object_create()
            pjones Peter Jones made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Reopened [ 4 ] New: Resolved [ 5 ]
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.5.1 [ 10608 ]
            Labels Original: coccinelle prz zfs New: coccinelle zfs
            pjones Peter Jones made changes -
            Resolution Original: Fixed [ 1 ]
            Status Original: Closed [ 6 ] New: Reopened [ 4 ]
            jessica Jessica A. Popp (Inactive) made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Reopened [ 4 ] New: Closed [ 6 ]
            jessica Jessica A. Popp (Inactive) made changes -
            Labels Original: coccinelle zfs New: coccinelle prz zfs
            jessica Jessica A. Popp (Inactive) made changes -
            Resolution Original: Fixed [ 1 ]
            Status Original: Closed [ 6 ] New: Reopened [ 4 ]
            jhammond John Hammond made changes -
            Status Original: Resolved [ 5 ] New: Closed [ 6 ]
            jhammond John Hammond made changes -
            Fix Version/s New: Lustre 2.6.0 [ 10595 ]
            Resolution New: Fixed [ 1 ]
            Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-2753 [ LU-2753 ]
            jhammond John Hammond made changes -
            Status Original: Open [ 1 ] New: In Progress [ 3 ]

            People

              jhammond John Hammond
              jhammond John Hammond
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: