Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-4262

intent opcodes not in wire{check,test}, some misdefined in packet-lustre.c

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • None
    • Lustre 2.6.0
    • 3
    • 11704

    Description

      Intent opcodes are put on the wire in ldlm_intent but have no consistency checks in wiretest or wirecheck.

      Moreover some of the definitions in wireshark's packet lustre are wrong. From obd.h:

      #define IT_OPEN     (1 << 0)
      #define IT_CREAT    (1 << 1)
      #define IT_READDIR  (1 << 2)
      #define IT_GETATTR  (1 << 3)
      #define IT_LOOKUP   (1 << 4)
      #define IT_UNLINK   (1 << 5)
      #define IT_TRUNC    (1 << 6)
      #define IT_GETXATTR (1 << 7)
      #define IT_EXEC     (1 << 8)
      #define IT_PIN      (1 << 9)
      #define IT_LAYOUT   (1 << 10)
      #define IT_QUOTA_DQACQ (1 << 11)
      #define IT_QUOTA_CONN  (1 << 12)
      #define IT_SETXATTR (1 << 13)
      

      From packet-lustre.c

      #define IT_OPEN     0x0001
      #define IT_CREAT    0x0002
      #define IT_READDIR  0x0004
      #define IT_GETATTR  0x0008
      #define IT_LOOKUP   0x0010
      #define IT_UNLINK   0x0020
      #define IT_GETXATTR 0x0040
      #define IT_EXEC     0x0080
      #define IT_PIN      0x0100
      

      Attachments

        Issue Links

          Activity

            People

              utopiabound Nathaniel Clark
              jhammond John Hammond
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: