Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6353

Push Wireshark Support Upstream

Details

    • 17786

    Description

      It would be good if we can push Wireshark support files upstream (Wireshark project) so we can delete them from our own repository. The two files in question are packet_lnet.c and packet_lustre.c.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. LU-8657 Wireshark dissectors for Lustre fail to build against Wireshark 2.2.0 source.

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-9050 Wireshark build support enhancement

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-6630 ldlm_intent_getattr_client RPC mbo_valid flags do not match those returned

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. LU-8499 wireshark plugins don't build any more

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-4262 intent opcodes not in wire{check,test}, some misdefined in packet-lustre.c

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-6582 Wireshark fails to parse LDLM_ENQUEUE RPC - likely for layout lock

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-6648 Wireshark 1.8.10 does not correctly parse LDLM_ENQUEUE intent : getxattr

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-6671 Wireshark: LDLM_ENQUEUE reply with undecoded buffer

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LU-4378 Add HSM message parsing to wireshark plugins

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-6353] Push Wireshark Support Upstream
            gerrit Gerrit Updater added a comment -

            John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/31258/
            Subject: LU-6353 contrib: Remove wireshark plugin
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set:
            Commit: e744675fbd4e6d50611816c72055c84c4f4fd303

            gerrit Gerrit Updater added a comment - John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/31258/ Subject: LU-6353 contrib: Remove wireshark plugin Project: fs/lustre-release Branch: b2_10 Current Patch Set: Commit: e744675fbd4e6d50611816c72055c84c4f4fd303
            gerrit Gerrit Updater added a comment -

            Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/31258
            Subject: LU-6353 contrib: Remove wireshark plugin
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set: 1
            Commit: 741edd17f945502ad82b97ab9664a382c66d6aab

            gerrit Gerrit Updater added a comment - Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/31258 Subject: LU-6353 contrib: Remove wireshark plugin Project: fs/lustre-release Branch: b2_10 Current Patch Set: 1 Commit: 741edd17f945502ad82b97ab9664a382c66d6aab
            pjones Peter Jones added a comment -

            Landed for 2.11

            pjones Peter Jones added a comment - Landed for 2.11
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30602/
            Subject: LU-6353 contrib: Remove wireshark plugin
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 4b5206bcf18c71ecc1291219af560298bf7517e3

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30602/ Subject: LU-6353 contrib: Remove wireshark plugin Project: fs/lustre-release Branch: master Current Patch Set: Commit: 4b5206bcf18c71ecc1291219af560298bf7517e3
            utopiabound Nathaniel Clark added a comment -

            All my patches have landed upstream, once we remove the plugins from the lustre tree, this can be closed.

            utopiabound Nathaniel Clark added a comment - All my patches have landed upstream, once we remove the plugins from the lustre tree, this can be closed.
            gerrit Gerrit Updater added a comment -

            Nathaniel Clark (nathaniel.l.clark@intel.com) uploaded a new patch: https://review.whamcloud.com/30602
            Subject: LU-6353 contrib: Remove wireshark plugin
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: ae0bebf5778f6714a28c3b49a2ed950d43352617

            gerrit Gerrit Updater added a comment - Nathaniel Clark (nathaniel.l.clark@intel.com) uploaded a new patch: https://review.whamcloud.com/30602 Subject: LU-6353 contrib: Remove wireshark plugin Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: ae0bebf5778f6714a28c3b49a2ed950d43352617
            utopiabound Nathaniel Clark added a comment -

            After discussion with Wireshark Devs the above changes have been squashed to the following:
            https://code.wireshark.org/review/24796 Infiniband: Fix number of bytes exported if ip_cm_sid
            https://code.wireshark.org/review/24795 [lnet] Initial Lustre Network Support
            https://code.wireshark.org/review/24800 [lustre] Initial Lustre stupport

            utopiabound Nathaniel Clark added a comment - After discussion with Wireshark Devs the above changes have been squashed to the following: https://code.wireshark.org/review/24796 Infiniband: Fix number of bytes exported if ip_cm_sid https://code.wireshark.org/review/24795 [lnet] Initial Lustre Network Support https://code.wireshark.org/review/24800 [lustre] Initial Lustre stupport
            utopiabound Nathaniel Clark added a comment - - edited

            I've cleaned up the lnet and lustre wireshark plugins and pushed them up as a patch-chain for wireshark master:
            https://code.wireshark.org/review/#/q/topic:plugins-lustre

            https://code.wireshark.org/review/24795 [lnet] Initial Lustre Network Support
            https://code.wireshark.org/review/24796 Infiniband: Fix number of bytes exported if ip_cm_sid
            https://code.wireshark.org/review/24797 [lnet] Export shared values from LNET
            https://code.wireshark.org/review/24798 [lnet] fix tree types and cleanup NID processing
            https://code.wireshark.org/review/24799 [lnet] Fixup definitions from check scripts
            https://code.wireshark.org/review/24800 [lustre] Initial Lustre stupport
            https://code.wireshark.org/review/24801 [lnet] Export NID dissector
            https://code.wireshark.org/review/24802 [lnet] Fix payload length for MSG_PUT_REQ
            https://code.wireshark.org/review/24803 [lustre] Add MGS opcode dissection
            https://code.wireshark.org/review/24804 [lustre] Dissect OBD opcodes
            https://code.wireshark.org/review/24805 [lustre] Add LLOG opcode processing
            https://code.wireshark.org/review/24806 [lustre] Add QUOTA dissection
            https://code.wireshark.org/review/24807 [lustre] Add SEQ dissection
            https://code.wireshark.org/review/24808 [lustre] Add OUT, FLD, and SEC dissection
            https://code.wireshark.org/review/24809 [lustre] Add LFSCK dissection
            https://code.wireshark.org/review/24810 [lustre] Add MDS REINT SETATTR
            https://code.wireshark.org/review/24811 [lustre] Ensure subtrees are correctly defined
            https://code.wireshark.org/review/24812 [lustre] Add llog eadata dissection

            utopiabound Nathaniel Clark added a comment - - edited I've cleaned up the lnet and lustre wireshark plugins and pushed them up as a patch-chain for wireshark master: https://code.wireshark.org/review/#/q/topic:plugins-lustre https://code.wireshark.org/review/24795 [lnet] Initial Lustre Network Support https://code.wireshark.org/review/24796 Infiniband: Fix number of bytes exported if ip_cm_sid https://code.wireshark.org/review/24797 [lnet] Export shared values from LNET https://code.wireshark.org/review/24798 [lnet] fix tree types and cleanup NID processing https://code.wireshark.org/review/24799 [lnet] Fixup definitions from check scripts https://code.wireshark.org/review/24800 [lustre] Initial Lustre stupport https://code.wireshark.org/review/24801 [lnet] Export NID dissector https://code.wireshark.org/review/24802 [lnet] Fix payload length for MSG_PUT_REQ https://code.wireshark.org/review/24803 [lustre] Add MGS opcode dissection https://code.wireshark.org/review/24804 [lustre] Dissect OBD opcodes https://code.wireshark.org/review/24805 [lustre] Add LLOG opcode processing https://code.wireshark.org/review/24806 [lustre] Add QUOTA dissection https://code.wireshark.org/review/24807 [lustre] Add SEQ dissection https://code.wireshark.org/review/24808 [lustre] Add OUT, FLD, and SEC dissection https://code.wireshark.org/review/24809 [lustre] Add LFSCK dissection https://code.wireshark.org/review/24810 [lustre] Add MDS REINT SETATTR https://code.wireshark.org/review/24811 [lustre] Ensure subtrees are correctly defined https://code.wireshark.org/review/24812 [lustre] Add llog eadata dissection

            People

              utopiabound Nathaniel Clark
              doug Doug Oucharek (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: