[LU-6671] Wireshark: LDLM_ENQUEUE reply with undecoded buffer

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.11.0
• Labels: wireshark
• Severity: 3
• Assignee: Nathaniel Clark
• Reporter: Andrew Uselton (Inactive)

Description

The attached file is the tcpdump on a client where I ran a "truncate" test ('multiop <file> OTc 1024'). After the MDS_REINT request and reply there is an LDLM_ENQUEUE request and reply for an extent lock. The "verbose" tshark output shows in the header that there are three buffers:

Lm Buflens: 152
Lm Buflens: 112
Lm Buflens: 56

But only the first two 'ptlrpc_body' and 'ldlm_reply' get decoded or even mentioned. I am guessing the thrid buffer is an ost_lvb, but I could well be wrong.
-Andrew

Issue Links

• is related to: LU-8499 wireshark plugins don't build any more
• is related to: LU-6353 Push Wireshark Support Upstream
• is related to: LU-6582 Wireshark fails to parse LDLM_ENQUEUE RPC - likely for layout lock
• is related to: LU-6648 Wireshark 1.8.10 does not correctly parse LDLM_ENQUEUE intent : getxattr
• is related to: LU-4931 New feature of giving server/storage side advice of accessing file
• is related to: LU-4378 Add HSM message parsing to wireshark plugins

Comments

[Nathaniel Clark]

Sure, I've got no outstanding wireshark patches.

[Peter Jones]

Can this ticket be marked as resolved with the most recent landing?

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/18061/
Subject: LU-6671 wireshark: Process mds_md entries
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 57661182dbcdc2ec92dfafdeded078ab8ef8b7c6

[Kenrick Rawlings (Inactive)]

Andreas, recent progress has been slow since the focus has been on the Shared Secret Key functionality itself, but yes this is an ongoing process. From an initial review of the the patches, I don't see any issues with including them in the packet-lustre.c update we're working on and pushing them upstream along with it sounds great. We'll plan on doing that and will report back if we encounter difficulties.

[Andreas Dilger]

Nathan Lavender,
there are a number of patches that add wireshark decoding functionality under this ticket in Gerrit:
http://review.whamcloud.com/14552 "LU-4378 wireshark: Add parsing for HSM commands"
http://review.whamcloud.com/14732 "LU-6582 wireshark: Add new LDLM intent bits"
http://review.whamcloud.com/14961 "LU-6648 wireshark: Process ldlm intent getxattr"
http://review.whamcloud.com/18061 "LU-6671 wireshark: Process mds_md entries"

and separately two patches that add the ladvise functionality (the second one fixes breakage from the first):

http://review.whamcloud.com/10029 "LU-4931 ladvise: Add feature of giving file access advices" (packet-lustre.c part only)
http://review.whamcloud.com/22074 "LU-8499 wireshark: fix packet-lustre so it compiles"

It would be great to include these into the packet-lustre.c update that you are working on to push upstream along with the sptlrpc decoders. Is that an ongoing process, or is it currently on hold?

[Gerrit Updater]

Amir Shehata ([e-mail]) uploaded a new patch: http://review.whamcloud.com/22422
Subject: LU-6671 wireshark: Fix compile issues
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 687590ae46077888a0bcaf0cdbdf8670214c06e8

[Gerrit Updater]

Nathaniel Clark ([e-mail]) uploaded a new patch: http://review.whamcloud.com/18061
Subject: LU-6671 wireshark: Process mds_md entries
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9955da227dd414f1441cf659861a70a4f5c4de77