[LU-4362] cfs_hash_rehash_key() passed wrong parameters to cfs_hash_keycpy

• Type: Bug
• Resolution: Fixed
• Priority: Blocker
• Fix Version/s: Lustre 2.6.0, Lustre 2.4.2, Lustre 2.5.1
• Affects Version/s: Lustre 2.4.1, Lustre 2.5.0, Lustre 2.6.0
• Severity: 3
• Assignee: Liang Zhen (Inactive)
• Reporter: Liang Zhen (Inactive)

Description

cfs_hash_rehash_key()->cfs_hash_keycpy(hs, new_key, hnode);
but define of cfs_hash_keycpy is:
void cfs_hash_keycpy(cfs_hash_t *hs, struct hlist_node *hnode, void *key)

This is very dangerous because it can corrupt memory.
I will post a patch soon

Comments

[Peter Jones]

Landed for 2.4.2 and 2.6. Will land for 2.5.1 shortly

[Liang Zhen (Inactive)]

Karsten, I will add const for key type in upcoming patch, which can prevent this from happening.

[Karsten Weiss]

IMHO the interesting question is: Why couldn't the compiler help to prevent this bug as a type error in the first place? Wouldn't it help if the prototype of cfs_hash_keycpy() did not use a void* type for the "key" argument?

[Liang Zhen (Inactive)]

patch for master: http://review.whamcloud.com/8509
patch for b2_4: http://review.whamcloud.com/8510
patch for b2_1: http://review.whamcloud.com/8511
patch for b2_5: http://review.whamcloud.com/8512