[LU-4478] ldiskfs_fill_super() problems when ldiskfs_acct_on() fails.

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.6.0, Lustre 2.5.3
• Affects Version/s: Lustre 2.5.0
• Labels: duu ldiskfs patch
• Severity: 3
• Assignee: Yang Sheng
• Reporter: Li Xi (Inactive)

Description

Because of a change I made to ldiskfs_acct_on(), it returned a failure. ldiskfs_fill_super() did not handle it corrently, and following problem shew up.

LDISKFS-fs (sdb3): Can't enable usage tracking on a filesystem with the QUOTA feature set
LDISKFS-fs (sdb3): mount failed
-----------[ cut here ]-----------
WARNING: at fs/proc/generic.c:847 remove_proc_entry+0x24f/0x260() (Not tainted)
Hardware name: KVM
remove_proc_entry: removing non-empty directory 'ldiskfs/sdb3', leaking at least 'prealloc_table'
Modules linked in: ldiskfs lustre lov osc mdc fid fld ksocklnd ptlrpc obdclass lnet sha512_generic sha256_generic libcfs nfs lockd fscache auth_rpcgss nfs_acl sunrpc ipv6 microcode virtio_balloon 8139too 8139cp mii i2c_piix4 i2c_core sg ext4 jbd2 mbcache sd_mod crc_t10dif virtio_pci virtio_ring virtio pata_acpi ata_generic ata_piix dm_mirror dm_region_hash dm_log dm_mod [last unloaded: ldiskfs]
Pid: 21482, comm: mount Not tainted 2.6.32 #4
Call Trace:
[<ffffffff8106e3e7>] ? warn_slowpath_common+0x87/0xc0
[<ffffffff8106e4d6>] ? warn_slowpath_fmt+0x46/0x50
[<ffffffff811ef05d>] ? xlate_proc_name+0x4d/0xd0
[<ffffffff811ef3bf>] ? remove_proc_entry+0x24f/0x260
[<ffffffff8116dd05>] ? free_percpu+0xb5/0x140
[<ffffffffa0bcb52c>] ? ldiskfs_fill_super+0x24c/0x2960 [ldiskfs]
[<ffffffff81183d5e>] ? get_sb_bdev+0x18e/0x1d0
[<ffffffffa0bcb2e0>] ? ldiskfs_fill_super+0x0/0x2960 [ldiskfs]
[<ffffffffa0bc56e8>] ? ldiskfs_get_sb+0x18/0x20 [ldiskfs]
[<ffffffff811831cb>] ? vfs_kern_mount+0x7b/0x1b0
[<ffffffff81183372>] ? do_kern_mount+0x52/0x130
[<ffffffff811a3582>] ? do_mount+0x2d2/0x8d0
[<ffffffff811a1372>] ? copy_mount_options+0xf2/0x1a0
[<ffffffff811a3c10>] ? sys_mount+0x90/0xe0
[<ffffffff8100b072>] ? system_call_fastpath+0x16/0x1b
--[ end trace d57c133cb466eccd ]--
BUG: unable to handle kernel NULL pointer dereference at 00000000000001e0
IP: [<ffffffffa0bc65d4>] ldiskfs_clear_inode+0x24/0x50 [ldiskfs]
PGD 0
Oops: 0000 1 SMP
last sysfs file: /sys/module/jbd2/initstate
CPU 0
Modules linked in: ldiskfs lustre lov osc mdc fid fld ksocklnd ptlrpc obdclass lnet sha512_generic sha256_generic libcfs nfs lockd fscache auth_rpcgss nfs_acl sunrpc ipv6 microcode virtio_balloon 8139too 8139cp mii i2c_piix4 i2c_core sg ext4 jbd2 mbcache sd_mod crc_t10dif virtio_pci virtio_ring virtio pata_acpi ata_generic ata_piix dm_mirror dm_region_hash dm_log dm_mod [last unloaded: ldiskfs]

Pid: 21482, comm: mount Tainted: G W --------------- 2.6.32 #4 Red Hat KVM
RIP: 0010:[<ffffffffa0bc65d4>] [<ffffffffa0bc65d4>] ldiskfs_clear_inode+0x24/0x50 [ldiskfs]
RSP: 0018:ffff880102983c18 EFLAGS: 00010292
RAX: 0000000000000000 RBX: ffff880103db5538 RCX: ffff88010316ccd0
RDX: 0000000000000000 RSI: ffff880103db5758 RDI: ffff880103db5538
RBP: ffff880102983c28 R08: b040000000000000 R09: fede24e99eb5d608
R10: 0000000000000000 R11: 7fffffffffffffff R12: ffff880103db5670
R13: ffffffff81a83fc0 R14: 0000000000000000 R15: ffff880066f0b360
FS: 00007fac923247e0(0000) GS:ffff880028200000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 00000000000001e0 CR3: 000000010261f000 CR4: 00000000000006f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process mount (pid: 21482, threadinfo ffff880102982000, task ffff880102541500)
Stack:
ffff880103db5670 ffff880103db5538 ffff880102983c48 ffffffff8119c96c
<d> ffff880103db5538 0000000000000001 ffff880102983c68 ffffffff8119d1a3
<d> ffff88010259a400 ffff880103db5538 ffff880102983c88 ffffffff8119c002
Call Trace:
[<ffffffff8119c96c>] clear_inode+0xac/0x140
[<ffffffff8119d1a3>] generic_drop_inode+0x33/0x80
[<ffffffff8119c002>] iput+0x62/0x70
[<ffffffff8119a2b7>] shrink_dcache_for_umount_subtree+0x217/0x2b0
[<ffffffff8119a386>] shrink_dcache_for_umount+0x36/0x60
[<ffffffff81182bdf>] generic_shutdown_super+0x1f/0xe0
[<ffffffff81182cd1>] kill_block_super+0x31/0x50
[<ffffffff8118310e>] deactivate_locked_super+0x4e/0x90
[<ffffffff81183d7d>] get_sb_bdev+0x1ad/0x1d0
[<ffffffffa0bcb2e0>] ? ldiskfs_fill_super+0x0/0x2960 [ldiskfs]
[<ffffffffa0bc56e8>] ldiskfs_get_sb+0x18/0x20 [ldiskfs]
[<ffffffff811831cb>] vfs_kern_mount+0x7b/0x1b0
[<ffffffff81183372>] do_kern_mount+0x52/0x130
[<ffffffff811a3582>] do_mount+0x2d2/0x8d0
[<ffffffff811a1372>] ? copy_mount_options+0xf2/0x1a0
[<ffffffff811a3c10>] sys_mount+0x90/0xe0
[<ffffffff8100b072>] system_call_fastpath+0x16/0x1b
Code: 1f 84 00 00 00 00 00 55 48 89 e5 53 48 83 ec 08 0f 1f 44 00 00 48 89 fb e8 ba a9 fe ff 48 8b 83 08 01 00 00 48 8b 80 e8 02 00 00 <48> 8b b8 e0 01 00 00 48 85 ff 74 0c 48 8d b3 58 02 00 00 e8 14
RIP [<ffffffffa0bc65d4>] ldiskfs_clear_inode+0x24/0x50 [ldiskfs]
RSP <ffff880102983c18>
CR2: 00000000000001e0
crash> q