Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.11.0
    • Lustre 2.1.0
    • None
    • 3
    • 9723

    Description

      # Skip these tests
      # bug number:  17466 18857
      ALWAYS_EXCEPT="61d   33a 33b    $REPLAY_SINGLE_EXCEPT"
      

      Bug 17466 was fixed in Dec, 2008. The test should be reviewed and removed from ALWAYS_EXCEPT.

      Attachments

        Issue Links

          Activity

            [LU-472] Revive replay-single 61d

            This was enabled in patch https://review.whamcloud.com/27404 "LU-9590 tests: remove replay-single tests from ALWAYS_EXCEPT".

            adilger Andreas Dilger added a comment - This was enabled in patch https://review.whamcloud.com/27404 " LU-9590 tests: remove replay-single tests from ALWAYS_EXCEPT".

            This patch fixes the test:
            http://review.whamcloud.com/1112
            This patch tries to fix problems revealed by the newly revived test:
            http://review.whamcloud.com/1113

            liwei Li Wei (Inactive) added a comment - This patch fixes the test: http://review.whamcloud.com/1112 This patch tries to fix problems revealed by the newly revived test: http://review.whamcloud.com/1113

            Hi Li Wei,
            Yes, i agree with you, this test should start/stop the MDS and not the MGS. We used to only test combo MGS & MDS, that's probably why we have never encountered such a problem before.

            johann Johann Lombardi (Inactive) added a comment - Hi Li Wei, Yes, i agree with you, this test should start/stop the MDS and not the MGS. We used to only test combo MGS & MDS, that's probably why we have never encountered such a problem before.

            Johann and Andreas, any comments?

            liwei Li Wei (Inactive) added a comment - Johann and Andreas, any comments?
            liwei Li Wei (Inactive) added a comment - - edited

            Since replay-single 61d's debut in Jul, 2008, the test has been led astray from its original mission. The historical changes described below should be reverted or fixed.

            llog_setup_named() and llog_setup(). Originally, the fault injection simulated what might happen when the "CATALOGS" internal file was corrupted. After the changes were applied, the fault started to be injected at the first call of llog_setup_named()/llog_setup() even when lop_setup was not implemented. In other words, a fault could be injected at locations that would never fail! Another issue in these changes is that replacing llog_ctxt_destroy() with llog_ctxt_put() causes lop_cleanup to be invoked upon lop_setup failures. In general, interfaces like lop_setup should clean things up before returning an error; lop_cleanup should not be called upon lop_setup failures.

            test_61d(). This change looks like a result of the fictional fault injection described above. The test should stop and start the MDT rather than the MGS.

            liwei Li Wei (Inactive) added a comment - - edited Since replay-single 61d's debut in Jul, 2008, the test has been led astray from its original mission . The historical changes described below should be reverted or fixed. llog_setup_named() and llog_setup() . Originally, the fault injection simulated what might happen when the "CATALOGS" internal file was corrupted. After the changes were applied, the fault started to be injected at the first call of llog_setup_named()/llog_setup() even when lop_setup was not implemented. In other words, a fault could be injected at locations that would never fail! Another issue in these changes is that replacing llog_ctxt_destroy() with llog_ctxt_put() causes lop_cleanup to be invoked upon lop_setup failures. In general, interfaces like lop_setup should clean things up before returning an error; lop_cleanup should not be called upon lop_setup failures. test_61d() . This change looks like a result of the fictional fault injection described above. The test should stop and start the MDT rather than the MGS.

            People

              liwei Li Wei (Inactive)
              liwei Li Wei (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: