Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-4739

Code inconsistencies when referring to config_llog_instance

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.9.0
    • None
    • 3
    • 13021

    Description

      While trying to search for other similar occurrences of an issue I was working to keep consistent with current coding conventions I found that there are two instances where the local variable pointer name of the config_llog_instance was inconsistent with the way it is done in other areas of the code.

      Most of the files do the following:
      struct config_llog_instance *cfg
      or
      struct config_llog_instance lcfg

      However,

      obd_config.c and obd_mount_server.c both have functions that use the following method:
      struct config_llog_instance *clli

      Attachments

        Activity

          [LU-4739] Code inconsistencies when referring to config_llog_instance

          Patch landed to master for 2.9.0

          jgmitter Joseph Gmitter (Inactive) added a comment - Patch landed to master for 2.9.0

          Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/10420/
          Subject: LU-4739 obd: Fixing code inconsistencies and coding style
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: db5156ee281f8ba929bcf223d062c6f0735e9142

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/10420/ Subject: LU-4739 obd: Fixing code inconsistencies and coding style Project: fs/lustre-release Branch: master Current Patch Set: Commit: db5156ee281f8ba929bcf223d062c6f0735e9142
          bobbielind Bobbie Lind (Inactive) added a comment - Patch submitted. http://review.whamcloud.com/10420

          Bobbi, it would be great if you could submit a patch to clean this up, along with fixing up the coding style in the affected functions (so checkpatch.pl passes cleanly).

          adilger Andreas Dilger added a comment - Bobbi, it would be great if you could submit a patch to clean this up, along with fixing up the coding style in the affected functions (so checkpatch.pl passes cleanly).

          People

            utopiabound Nathaniel Clark
            bobbielind Bobbie Lind (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: