[LU-5187] Make "precreate FID" console message more intelligible

• Type: Technical task
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.8.0
• Labels: llnl
• Assignee: Nathaniel Clark
• Reporter: Christopher Morrone (Inactive)

Description

Brian Behlendorf points out in the comments on patch 10394 that the following console warning message is not particularly intelligible as it stands.

From lustre/ofd/ofd_dev.c:

                /* This can happen if a new OST is formatted and installed
                 * in place of an old one at the same index.  Instead of
                 * precreating potentially millions of deleted old objects
                 * (possibly filling the OST), only precreate the last batch.
                 * LFSCK will eventually clean up any orphans. LU-14 */
                if (diff > 5 * OST_MAX_PRECREATE) {
                        diff = OST_MAX_PRECREATE / 2;
                        LCONSOLE_WARN("%s: precreate FID "DOSTID" is over %u "
                                      "larger than the LAST_ID "DOSTID", only "
                                      "precreating the last %u objects.\n",
                                      ofd_name(ofd), POSTID(&oa->o_oi),
                                      5 * OST_MAX_PRECREATE,
                                      POSTID(&oseq->os_oi), diff);
                        ofd_seq_last_oid_set(oseq, ostid_id(&oa->o_oi) - diff);
                }

Brian said:

I still don't think the console message itself is at all useful. Either Lustre should silently handle this case (if it can) and we can silence the message. Or the console message should be updated to include clear explanation of what's wrong and what an administrator needs to do. As it stands, I feel it's just noise when is only useful to a developer.

I agree that this message needs improvment.

Comments

[Joseph Gmitter (Inactive)]

Landed for 2.8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/10767/
Subject: LU-5187 ofd: Fix precreate console warning
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d9683d9cd5ecf7dd2d0ff24492a2117c4c61356b

[Nathaniel Clark]

Chris,

There's a new revision with an altered Console warning (and the developer info is dumped into the HA debug level).

[Christopher Morrone (Inactive)]

Nathaniel, please see Andreas's review of revision 1 of patch 10394. Andreas rejected the idea of just changing the logging level. Therefore this ticket's intent is to rework the actual message into something that is understandable and actionable by a system administrator.

[Nathaniel Clark]

http://review.whamcloud.com/10767

[Peter Jones]

Nathaniel

Could you please assist with this one?

Thanks

Peter