Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-5442

unconditionally include libcfs.h in lustre_idl.h

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.7.0
    • Lustre 2.7.0
    • None
    • 3
    • 15156

    Description

      lustre_idl.h only includes libcfs.h if LPU64 is not defined:

      #if !defined(LPU64)
      #include <libcfs/libcfs.h> /* for LPUX64, etc */
      #endif
      

      Since the landing of LU-5327 libcfs: add libcfs/types.h it is possible to get definitions for LPU64 without including libcfs.h. (Technically it was always possible, but now it's much easier.)

      The outer include guard was added in LU-113: make lustre_

      {idl,user}

      .h nice to userspace. Since we no longer package lustre_idl.h we should remove this guard.

      Attachments

        Activity

          [LU-5442] unconditionally include libcfs.h in lustre_idl.h
          jhammond John Hammond added a comment -

          Patch landed to master.

          jhammond John Hammond added a comment - Patch landed to master.
          jhammond John Hammond added a comment - Please see http://review.whamcloud.com/11308 .

          People

            jhammond John Hammond
            jhammond John Hammond
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: