[LU-5829] too many EXPORT_SYMBOL in code

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.8.0
• Labels: patch
• Severity: 3
• Assignee: Cliff White (Inactive)
• Reporter: Frank Zago (Inactive)

Description

Lustre currently exports 1809 symbols, compared to 25395 symbols for the whole linux kernel.

A lot of these symbols don't need to be exported at all because they are only used in the module they belong to.

Issue Links

• is related to: LU-6215 Sync Lustre external tree with lustre linux kernel client

Comments

[Frank Zago (Inactive)]

Fix for that issue is in LU-8471.

[Andrew Perepechko]

frank zago ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13323

This patch is not correct. It removes e.g. lu_ref_add() export, but it is used from other modules (you can check with grep).
Builds with --enable-lu_ref are broken because of this change.

[Frank Zago (Inactive)]

Incorrect LU in commit. Please ignore that.

[Gerrit Updater]

frank zago ([e-mail]) uploaded a new patch: http://review.whamcloud.com/16482
Subject: LU-5829 quota: fixed invalid memset
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4d46ee296e4698f1d699a264d0e209d2fb1ce11d

[Peter Jones]

Landed for 2.8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13319/
Subject: LU-5829 libcfs: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 502c141440b4e6a75a1162d25ba98315abe7ca4e

[James A Simmons]

One patch left that once landed we can close this ticket.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13324/
Subject: LU-5829 ldlm: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e536e511c9e634d8cb7faf763ecab4cab5f40267

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13320/
Subject: LU-5829 lnet: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: db841c2218bd184f0b113e99c316b9039194859c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12510/
Subject: LU-5829 ptlrpc: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3ee0e0908f12de97346cd5fe2996ad147adb9481