Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-5849

DLC: parse networks function needs to return the number of parsed networks

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • Lustre 2.7.0
    • Lustre 2.7.0
    • 3
    • 16379

    Description

      lnet_dyn_add_ni() requires lnet_parse_networks() to return the number of nets (outside of LO) that were parsed in order to do proper sanity checks. Currently it returns < 0 for failure and 0 for failure.

      Attachments

        Issue Links

          Activity

            [LU-5849] DLC: parse networks function needs to return the number of parsed networks

            Has this been resolved due to the landing of LU-5374?

            simmonsja James A Simmons added a comment - Has this been resolved due to the landing of LU-5374?

            I think it's good chance now to clean up lnet_parse_networks(). It used to add a LO by itself only because it made sense to its only caller LNetNIInit(). Now the added LO can actually cause trouble to the new caller lnet_dyn_add_ni(), which doesn't want that LO at all.

            I think:
            1. lnet_parse_networks() should NOT add LO
            2. LNetNIInit() adds LO to the parsed NI list if lnet_parse_networks() returned OK.
            3. lnet_dyn_add_ni() now doesn't need to do anything special about the extra LO.

            isaac Isaac Huang (Inactive) added a comment - I think it's good chance now to clean up lnet_parse_networks(). It used to add a LO by itself only because it made sense to its only caller LNetNIInit(). Now the added LO can actually cause trouble to the new caller lnet_dyn_add_ni(), which doesn't want that LO at all. I think: 1. lnet_parse_networks() should NOT add LO 2. LNetNIInit() adds LO to the parsed NI list if lnet_parse_networks() returned OK. 3. lnet_dyn_add_ni() now doesn't need to do anything special about the extra LO.

            People

              ashehata Amir Shehata (Inactive)
              ashehata Amir Shehata (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: