[LU-5734] LNet dynamic control: lnet_dyn_add_ni() can't clean up failed NI in some cases

• Type: Bug
• Resolution: Fixed
• Priority: Blocker
• Fix Version/s: Lustre 2.7.0
• Affects Version/s: Lustre 2.7.0
• Severity: 3
• Assignee: Amir Shehata (Inactive)
• Reporter: Isaac Huang (Inactive)

Description

In lnet_dyn_add_ni(), if lnet_startup_lndnis() fails, then NI on the local &net_head list is freed. But lnet_startup_lndnis(&net_head) can fail after list_del(&ni->ni_list), i.e. after the NI has been removed already from the &net_head. In this case I failed to see where the NI gets cleaned up and freed.

Issue Links

• is related to: LU-5849 DLC: parse networks function needs to return the number of parsed networks
• is related to: LU-6002 DLC: startup acceptor dynamically.
• is related to: LU-5839 LNetNIInit() should not call lnet_destroy_routes() before lnet_parse_routes() has been called
• is related to: LU-5850 DLC: lnet_startup_lndnis should clean up after itself
• is related to: LU-5568 kernel crash when when network initialization failed
• is related to: LU-2456 Dynamic LNet Config Main Development Work