[LU-6055] sanity-hsm file_creation_failure sends df output to stdout

• Type: Bug
• Resolution: Fixed
• Priority: Blocker
• Fix Version/s: Lustre 2.7.0
• Affects Version/s: Lustre 2.7.0
• Labels: hsm test
• Severity: 3
• Assignee: John Hammond
• Reporter: John Hammond

Description

The file_creation_failure() function added to sanity-hsm calls df for debugging purposes but does not redirect the output of df to stderr. Since file_creation_failure is used in functions like make_large_for_cancel which are in turn used in command substitution

local f=$(make_large_for_cancel ...)

the df output goes into $f.

Also many of these functions check for success by calling path2fid which pipes lfs to tr

path2fid() {
        $LFS path2fid $1 | tr -d '[]'
}

Since tr will succeed this will fail to detect errors.

Issue Links

• is related to: LU-3852 sanity-hsm test_251: client26-vm "dd: no space left on device"

Comments

[Gerrit Updater]

James Nunez ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13827
Subject: LU-6055 hsm: improve error handling in sanity-hsm
Project: fs/lustre-release
Branch: b2_5
Current Patch Set: 1
Commit: 5773e67989e9b4953c1801d8c23572b126af8b78

[Jodi Levi (Inactive)]

Patch landed to Master.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13154/
Subject: LU-6055 hsm: improve error handling in sanity-hsm
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 27f65af06d0906856041cbcf2537cfabe2a90583

[Andreas Dilger]

It looks like this was introduced by http://review.whamcloud.com/12456 landing.

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13154
Subject: LU-6055 hsm: improve error handling in sanity-hsm
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1765a1a68870282994121a37a213d7ae0f4f4081