Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6160

all test builds should enable SPL/ZFS debugging

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • Lustre 2.12.0
    • None
    • 17226

    Description

      ASSERTs in SPL/ZFS are off by default. It'd be a good idea to enable SPL/ZFS assertions at least for test builds, which'd pinpoint problems much earlier before they manifest as hard-to-diagnose symptoms.

      I have a patch that enables SPL/ZFS debugging:
      http://review.whamcloud.com/#/c/13431/

      But there's build failures for i686 in SPL/ZFS. So upstream SPL/ZFS would need a fix for that.

      Attachments

        Issue Links

          Activity

            [LU-6160] all test builds should enable SPL/ZFS debugging

            Nathaniel Clark (nclark@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33604
            Subject: LU-6160 osd-zfs: Fix refcount_add call
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set: 1
            Commit: fe7bf8a315c6c995f9eb674bd15308ff8def7633

            gerrit Gerrit Updater added a comment - Nathaniel Clark (nclark@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33604 Subject: LU-6160 osd-zfs: Fix refcount_add call Project: fs/lustre-release Branch: b2_10 Current Patch Set: 1 Commit: fe7bf8a315c6c995f9eb674bd15308ff8def7633

            I see that Oleg landed the patch to allow Lustre to build against zfs packages with debug enabled.

            But were the appropriate change(s) made to your build system to enable debug in zfs for test builds?

            ofaaland Olaf Faaland added a comment - I see that Oleg landed the patch to allow Lustre to build against zfs packages with debug enabled. But were the appropriate change(s) made to your build system to enable debug in zfs for test builds?
            pjones Peter Jones added a comment -

            Landed for 2.12

            pjones Peter Jones added a comment - Landed for 2.12

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/28544/
            Subject: LU-6160 osd-zfs: Fix refcount_add call
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: ad7e62cc15e9e90d33a7302308d47566e4af3593

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/28544/ Subject: LU-6160 osd-zfs: Fix refcount_add call Project: fs/lustre-release Branch: master Current Patch Set: Commit: ad7e62cc15e9e90d33a7302308d47566e4af3593

            I'm submitting https://review.whamcloud.com/28544 just so lustre builds against zfs packages that have debug enabled.

            dinatale2 Giuseppe Di Natale (Inactive) added a comment - I'm submitting https://review.whamcloud.com/28544 just so lustre builds against zfs packages that have debug enabled.

            Giuseppe Di Natale (dinatale2@llnl.gov) uploaded a new patch: https://review.whamcloud.com/28544
            Subject: LU-6160 osd-zfs: Fix refcount_add call
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 510f1536aa60e11271d621e2171dc19bcf8c7a5b

            gerrit Gerrit Updater added a comment - Giuseppe Di Natale (dinatale2@llnl.gov) uploaded a new patch: https://review.whamcloud.com/28544 Subject: LU-6160 osd-zfs: Fix refcount_add call Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 510f1536aa60e11271d621e2171dc19bcf8c7a5b
            pjones Peter Jones added a comment -

            Assigining to Oleg for his comment

            pjones Peter Jones added a comment - Assigining to Oleg for his comment

            "ran" doesn't exactly mean it's reliable.. not that I'm against running with debug enabled, but there were known issues we never fixed, some can't be fixed outside of ZFS code.

            bzzz Alex Zhuravlev added a comment - "ran" doesn't exactly mean it's reliable.. not that I'm against running with debug enabled, but there were known issues we never fixed, some can't be fixed outside of ZFS code.

            I hear that Oleg successfully ran Lustre using ZFS built with debug enabled, and submitted patches for some bugs he found that way.

            Was Lustre patched to enable this, so that this ticket can now go forward? Or did he just make some one-off change in his environment, perhaps to ZFS, to enable this for testing purposes?

            ofaaland Olaf Faaland added a comment - I hear that Oleg successfully ran Lustre using ZFS built with debug enabled, and submitted patches for some bugs he found that way. Was Lustre patched to enable this, so that this ticket can now go forward? Or did he just make some one-off change in his environment, perhaps to ZFS, to enable this for testing purposes?

            well, I don't remember exact lines, but basically in debug mode DMU tracks all writes are declared properly (including offset/range), while LLOG doesn't know exact offset at declare.

            bzzz Alex Zhuravlev added a comment - well, I don't remember exact lines, but basically in debug mode DMU tracks all writes are declared properly (including offset/range), while LLOG doesn't know exact offset at declare.

            People

              green Oleg Drokin
              isaac Isaac Huang (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: