Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6160

all test builds should enable SPL/ZFS debugging

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • Lustre 2.12.0
    • None
    • 17226

    Description

      ASSERTs in SPL/ZFS are off by default. It'd be a good idea to enable SPL/ZFS assertions at least for test builds, which'd pinpoint problems much earlier before they manifest as hard-to-diagnose symptoms.

      I have a patch that enables SPL/ZFS debugging:
      http://review.whamcloud.com/#/c/13431/

      But there's build failures for i686 in SPL/ZFS. So upstream SPL/ZFS would need a fix for that.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-6155 osd_count_not_mapped() calls dbuf_hold_impl() without the lock

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-6195 osd-zfs: osd_declare_object_destroy() calls dmu_tx_hold_zap() with wrong keys

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-6160] all test builds should enable SPL/ZFS debugging
            gerrit Gerrit Updater added a comment -

            Giuseppe Di Natale (dinatale2@llnl.gov) uploaded a new patch: https://review.whamcloud.com/28544
            Subject: LU-6160 osd-zfs: Fix refcount_add call
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 510f1536aa60e11271d621e2171dc19bcf8c7a5b

            gerrit Gerrit Updater added a comment - Giuseppe Di Natale (dinatale2@llnl.gov) uploaded a new patch: https://review.whamcloud.com/28544 Subject: LU-6160 osd-zfs: Fix refcount_add call Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 510f1536aa60e11271d621e2171dc19bcf8c7a5b
            pjones Peter Jones added a comment -

            Assigining to Oleg for his comment

            pjones Peter Jones added a comment - Assigining to Oleg for his comment
            bzzz Alex Zhuravlev added a comment -

            "ran" doesn't exactly mean it's reliable.. not that I'm against running with debug enabled, but there were known issues we never fixed, some can't be fixed outside of ZFS code.

            bzzz Alex Zhuravlev added a comment - "ran" doesn't exactly mean it's reliable.. not that I'm against running with debug enabled, but there were known issues we never fixed, some can't be fixed outside of ZFS code.
            ofaaland Olaf Faaland added a comment -

            I hear that Oleg successfully ran Lustre using ZFS built with debug enabled, and submitted patches for some bugs he found that way.

            Was Lustre patched to enable this, so that this ticket can now go forward? Or did he just make some one-off change in his environment, perhaps to ZFS, to enable this for testing purposes?

            ofaaland Olaf Faaland added a comment - I hear that Oleg successfully ran Lustre using ZFS built with debug enabled, and submitted patches for some bugs he found that way. Was Lustre patched to enable this, so that this ticket can now go forward? Or did he just make some one-off change in his environment, perhaps to ZFS, to enable this for testing purposes?
            bzzz Alex Zhuravlev added a comment -

            well, I don't remember exact lines, but basically in debug mode DMU tracks all writes are declared properly (including offset/range), while LLOG doesn't know exact offset at declare.

            bzzz Alex Zhuravlev added a comment - well, I don't remember exact lines, but basically in debug mode DMU tracks all writes are declared properly (including offset/range), while LLOG doesn't know exact offset at declare.
            isaac Isaac Huang (Inactive) added a comment -

            Alex, can you please point me to the code?

            isaac Isaac Huang (Inactive) added a comment - Alex, can you please point me to the code?
            bzzz Alex Zhuravlev added a comment -

            I think Lustre isn't quite ready for this yet. in some cases (like append to llog) we can't declare in the way ZFS's debugging expects.

            bzzz Alex Zhuravlev added a comment - I think Lustre isn't quite ready for this yet. in some cases (like append to llog) we can't declare in the way ZFS's debugging expects.

            People

              green Oleg Drokin
              isaac Isaac Huang (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: