Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-618

Reads are not included in IO accounting

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.11.0, Lustre 2.10.3
    • Lustre 1.8.7, Lustre 1.8.6
    • None
    • Linux, Lustre b1_8
    • 3
    • 24,536
    • 9730

    Description

      Writes are accounted for, but not reads. The supplied patch fixes this.

      It seems that the accounting it normally done in the kernels page writeback and readahead
      functionality. Therefore as Lustre implements its own readahead, it must also maintain its own
      accounting on reads (but not writes).

      Previously discussed in:

      Attachments

        Issue Links

          Activity

            [LU-618] Reads are not included in IO accounting

            John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/30570/
            Subject: LU-618 llite: IO accounting of page read
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set:
            Commit: 19f21a32e74fd347f03c90b33b3d75ee537bf0e7

            gerrit Gerrit Updater added a comment - John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/30570/ Subject: LU-618 llite: IO accounting of page read Project: fs/lustre-release Branch: b2_10 Current Patch Set: Commit: 19f21a32e74fd347f03c90b33b3d75ee537bf0e7

            Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/30570
            Subject: LU-618 llite: IO accounting of page read
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set: 1
            Commit: 6f8fb1839bafac7a52dee5779c065fad337d526f

            gerrit Gerrit Updater added a comment - Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/30570 Subject: LU-618 llite: IO accounting of page read Project: fs/lustre-release Branch: b2_10 Current Patch Set: 1 Commit: 6f8fb1839bafac7a52dee5779c065fad337d526f
            pjones Peter Jones added a comment -

            Landed for 2.11

            pjones Peter Jones added a comment - Landed for 2.11

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/1636/
            Subject: LU-618 llite: IO accounting of page read
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 48de9b195d71cb57ee50636d75c59d78ee068cee

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/1636/ Subject: LU-618 llite: IO accounting of page read Project: fs/lustre-release Branch: master Current Patch Set: Commit: 48de9b195d71cb57ee50636d75c59d78ee068cee

            the patch https://review.whamcloud.com/#/c/1636 has been updated against the latest master.

            hongchao.zhang Hongchao Zhang added a comment - the patch https://review.whamcloud.com/#/c/1636 has been updated against the latest master.

            the patch has been refreshed

            hongchao.zhang Hongchao Zhang added a comment - the patch has been refreshed

            This conflict with RHEL5 is probably gone, should the patch be refreshed?

            adilger Andreas Dilger added a comment - This conflict with RHEL5 is probably gone, should the patch be refreshed?

            there is a bug in OFED(1.5.3.2) which causes the patch can't be builded successfully in RHEL5, the detailed info is,

            for RHEL5, there is no "task_io_account_cancelled_write" definition prior to 2.6.18-164.2.1 and is okay for OFED, which
            defines the same function in the backport (in kernel_addons/backport directory), but the function is defined from
            2.6.18-164.2.1, then cause the redefinition error when building Lustre with OFED

            hongchao.zhang Hongchao Zhang added a comment - there is a bug in OFED(1.5.3.2) which causes the patch can't be builded successfully in RHEL5, the detailed info is, for RHEL5, there is no "task_io_account_cancelled_write" definition prior to 2.6.18-164.2.1 and is okay for OFED, which defines the same function in the backport (in kernel_addons/backport directory), but the function is defined from 2.6.18-164.2.1, then cause the redefinition error when building Lustre with OFED
            hongchao.zhang Hongchao Zhang added a comment - - edited

            its patch is tracked at https://review.whamcloud.com/#/c/1636

            hongchao.zhang Hongchao Zhang added a comment - - edited its patch is tracked at https://review.whamcloud.com/#/c/1636
            pjones Peter Jones added a comment -

            Hongchao

            Please can you take care of porting this patch to master

            Thanks

            Peter

            pjones Peter Jones added a comment - Hongchao Please can you take care of porting this patch to master Thanks Peter

            People

              hongchao.zhang Hongchao Zhang
              mark Mark Hills
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: