Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6219

Unnecessary usage of O_NONBLOCK flag for archive file by copytool/lhsm_posix

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.8.0
    • None
    • None
    • 3
    • 17395

    Description

      In the first implementations of Posix copytool, file archive/restore was using a loop around select() with handling/retry on EAGAIN.
      This was later found as useless for regular files and fixed/changed in patch for LU-3971 (http://review.whamcloud.com/7583, commit 397ebc93cef378e6d77450cdd095e2737b94f2f6).
      But the O_NONBLOCK flag usage, during open() of file on archive, has been kept since and must be removed, even if ineffective, to improve code clarity.

      Attachments

        Activity

          [LU-6219] Unnecessary usage of O_NONBLOCK flag for archive file by copytool/lhsm_posix

          Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13672/
          Subject: LU-6219 utils: remove O_NONBLOCK usage for archive file
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 24f96966d7c85c1e2ffdaa1be314039a0f5cf422

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13672/ Subject: LU-6219 utils: remove O_NONBLOCK usage for archive file Project: fs/lustre-release Branch: master Current Patch Set: Commit: 24f96966d7c85c1e2ffdaa1be314039a0f5cf422

          Patch to remove the useless usage of O_NONBLOCK flag for archive file is at http://review.whamcloud.com/13672.

          bfaccini Bruno Faccini (Inactive) added a comment - Patch to remove the useless usage of O_NONBLOCK flag for archive file is at http://review.whamcloud.com/13672 .

          Faccini Bruno (bruno.faccini@intel.com) uploaded a new patch: http://review.whamcloud.com/13672
          Subject: LU-6219 utils: remove O_NONBLOCK usage for archive file
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: b5883d7c41d1a90feaa48f182c8cfc0432957c77

          gerrit Gerrit Updater added a comment - Faccini Bruno (bruno.faccini@intel.com) uploaded a new patch: http://review.whamcloud.com/13672 Subject: LU-6219 utils: remove O_NONBLOCK usage for archive file Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: b5883d7c41d1a90feaa48f182c8cfc0432957c77

          People

            bfaccini Bruno Faccini (Inactive)
            bfaccini Bruno Faccini (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: