[LU-6499] leaking a kernel device on error in init_obdclass

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.10.0
• Affects Version/s: Lustre 2.8.0
• Labels: easy
• Severity: 3
• Assignee: Bruno Faccini (Inactive)
• Reporter: Oleg Drokin

Description

Highlighted by smatch:

init_obdclass has this nice code:

        err = misc_register(&obd_psdev);
        if (err) {
                CERROR("cannot register %d err %d\n", OBD_DEV_MINOR, err);
                return err;
        }
...
        err = obd_init_caches();
        if (err)
                return err;
        err = class_procfs_init();
        if (err)
                return err;

        err = lu_global_init();
        if (err)
                return err;

        err = lu_capainfo_init();
        if (err)
                return err;
...

leaking reference to the just registered device.
We should really be freeing it on all subsequent errors.

Comments

[Peter Jones]

Landed for 2.10

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/22544/
Subject: LU-6499 obdclass: obdclass module cleanup upon load error
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e4761eb1f4d564f111be66a61ac84f9f9be97fc2

[Bruno Faccini (Inactive)]

On behalf of "Gerrit Updater", I am manually adding the following comment because it had been originally added to a wrong ticket (LU-6449) due to a typo in the header/1st-line of commit-msg ... :

Faccini Bruno ([e-mail]) uploaded a new patch: http://review.whamcloud.com/22544
Subject: LU-6499 obdclass: obdclass module cleanup upon load error
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 18eba47083e13dbb0dd355de57042634a189b0a0