[LU-6499] leaking a kernel device on error in init_obdclass

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.10.0
• Affects Version/s: Lustre 2.8.0
• Labels: easy
• Severity: 3
• Assignee: Bruno Faccini (Inactive)
• Reporter: Oleg Drokin

Description

Highlighted by smatch:

init_obdclass has this nice code:

        err = misc_register(&obd_psdev);
        if (err) {
                CERROR("cannot register %d err %d\n", OBD_DEV_MINOR, err);
                return err;
        }
...
        err = obd_init_caches();
        if (err)
                return err;
        err = class_procfs_init();
        if (err)
                return err;

        err = lu_global_init();
        if (err)
                return err;

        err = lu_capainfo_init();
        if (err)
                return err;
...

leaking reference to the just registered device.
We should really be freeing it on all subsequent errors.