Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6509

dead code in nodemap_create

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • Lustre 2.8.0
    • None
    • 3
    • 9223372036854775807

      Highlighted by smatch in nodemap_create:

      ...
              rc = nm_member_init_hash(nodemap);
              if (rc != 0) {
                      OBD_FREE_PTR(nodemap);
                      goto out;
              }
      ... (not touching rc at all)
              if (rc == 0) {
                      nodemap_putref(nodemap);
                      goto out;
              }
      
              CERROR("cannot add nodemap: '%s': rc = %d\n", name, rc);
              nodemap_destroy(nodemap);
      
      out:
              return rc;
      

      I wonder if this is a stub waiting for some more code or something was forgotten or what?

            wc-triage WC Triage
            green Oleg Drokin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: