[LU-6509] dead code in nodemap_create

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.8.0
• Labels: smatch
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

Highlighted by smatch in nodemap_create:

...
        rc = nm_member_init_hash(nodemap);
        if (rc != 0) {
                OBD_FREE_PTR(nodemap);
                goto out;
        }
... (not touching rc at all)
        if (rc == 0) {
                nodemap_putref(nodemap);
                goto out;
        }

        CERROR("cannot add nodemap: '%s': rc = %d\n", name, rc);
        nodemap_destroy(nodemap);

out:
        return rc;

I wonder if this is a stub waiting for some more code or something was forgotten or what?

Issue Links

• is related to: LU-5092 nodemap: transfer idmaps between MGS, MDT, OST