Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6522

doble semaphore unlock in loop_thread

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not a Bug
    • Icon: Minor Minor
    • None
    • None
    • None
    • 3
    • 9223372036854775807

      smatch has highlighted this gem in loop_thread():

              /*
         * up sem, we are running
         */
        up(&lo->lo_sem);

... {BIG HONKING LOOP} ...
out:
        up(&lo->lo_sem);
        return ret;

      I imagine when the loop terminates we don't care anymore, but still it just looks wrong and probably should be fixed?

            wc-triage WC Triage
            green Oleg Drokin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: