[LU-6522] doble semaphore unlock in loop_thread

• Type: Bug
• Resolution: Not a Bug
• Priority: Minor
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

smatch has highlighted this gem in loop_thread():

        /*
         * up sem, we are running
         */
        up(&lo->lo_sem);

... {BIG HONKING LOOP} ...
out:
        up(&lo->lo_sem);
        return ret;

I imagine when the loop terminates we don't care anymore, but still it just looks wrong and probably should be fixed?

Issue Links

• is related to: LU-8844 Delete llite lloop with fire!!!