[LU-6589] llapi_layout_pattern_set() rejects valid pattern values

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.8.0
• Labels: patch
• Severity: 3
• Assignee: Yang Sheng
• Reporter: Robert Read

Description

The input validation for this function appears to have a typo. Presumably "&&" was intended instead of "||":

	if (pattern != LLAPI_LAYOUT_DEFAULT ||
	    pattern != LLAPI_LAYOUT_RAID0) {
		errno = EOPNOTSUPP;
		return -1;
	}

Comments

[Peter Jones]

Landed for 2.8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14784/
Subject: LU-6589 llapi: ..._layout_pattern_set() rejects valid patterns
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1d700aaf9ff785e062d8e4c6a8920f37265dd969

[Robert Read]

No worries - I had to stare at it for a few minutes to convince myself it actually was as broken as I thought it was.

[Andreas Dilger]

My bad, didn't read the code correctly...

[Robert Read]

This also rejects LLAPI_LAYOUT_DEFAULT, too.

I noticed this problem while writing unit tests for my own tool.

[Peter Jones]

Yang Sheng

Could you please take care of this patch?

Thanks

Peter

[Gerrit Updater]

Ned Bass ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14784
Subject: LU-6589 llapi: ..._layout_pattern_set() rejects valid patterns
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3ffaa9456818da1e29231a317247bc2faa64b31d

[Ned Bass (Inactive)]

I think Robert is right--it will reject any value other than LLAPI_LAYOUT_DEFAULT. I'll whip up a patch.

[Andreas Dilger]

It isn't clear that this is actually a bug? LLAPI_LAYOUT_DEFAULT means "use the default values", so I can't see it makes sense to specify "use the default" at the same time as specifying something that may not be the default? Also, since LLAPI_LAYOUT_DEFAULT is not a simple bitfield it will also conflict with RAID0?

Ned, any comment on this API usage?

Robert, were you doing something in particular that failed this check, or merely code review?