[LU-6693] object_update_param_get inconsistent return value

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.8.0
• Severity: 3
• Assignee: Di Wang (Inactive)
• Reporter: Oleg Drokin

Description

Recent patch http://review.whamcloud.com/14787 added a code to object_update_param_get that returns PTR_ERR. But before it only returned NUL on error which all callers expect.
Now every caller is broken as they don't expect non NULL errors.

E.g. in out_xattr_set, out_read (twice). in target/out_handler.c

I think we need to convert object_update_param_get back to returning just NULL on error.

Comments

[Peter Jones]

Landed for 2.8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/16417/
Subject: LU-6693 out: not return NULL in object_update_param_get
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d059b3c01a9784b8da61ea99fb746e949d681b7e

[Gerrit Updater]

wangdi ([e-mail]) uploaded a new patch: http://review.whamcloud.com/16417
Subject: LU-6693 out: replace assert with error check in out_xx()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 942234aace34b48dc06cdbe0f112662f4eeba214

[Oleg Drokin]

This is not a full fix.
Remaining problems:

/home/green/smt/git/lustre-release/lustre/ptlrpc/../../lustre/target/out_lib.c:204 out_create_pack() error: 'obdo' dereferencing possible ERR_PTR()
/home/green/smt/git/lustre-release/lustre/ptlrpc/../../lustre/target/out_lib.c:252 out_attr_set_pack() error: 'obdo' dereferencing possible ERR_PTR()

[Di Wang (Inactive)]

http://review.whamcloud.com/#/c/12825/ has fixed this issue.