[LU-6714] llog_process_thread() may use wrong offset for the next block

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.8.0
• Severity: 3
• Assignee: Mikhail Pershin
• Reporter: Mikhail Pershin

Description

the llog_process_thread() save curent offset in last_offset variable before getting the new block of data, and uses it as the beginning of that block later. That can be wrong because new block can be read from different offset, depending on index being searched. We need to use the value returned by llog_next_block() call.

Issue Links

• is related to: LU-6944 LBUG: (osp_sync.c:1139:osp_sync_thread()) ASSERTION( thread->t_flags != SVC_RUNNING ) failed: 806 changes, 230 in progress, 7 in flight
• is related to: LU-9312 HSM coordinator llog scalability
• is related to: LU-5635 (llog.c:310:llog_process_thread()) ASSERTION( index <= last_index + 1 ) failed:

Comments

[Mikhail Pershin]

this ticket can be closed, the patch you mentioned is under different ticket already

[Peter Jones]

Mike

Doesn't this ticket need to remain open until http://review.whamcloud.com/#/c/15835/ lands? Or can this work be abandoned or tracked under another ticket #?

Peter

[Mikhail Pershin]

fix was landed

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/15841/
Subject: LU-6714 llog: fix the llog_cat_set_first_idx()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a830c06c612125cf517c66823078364c0c509de9

[Andreas Dilger]

Looks like the http://review.whamcloud.com/15841 patch is not landed yet.

[Gerrit Updater]

Mike Pershin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15841
Subject: LU-6714 llog: fix the llog_cat_set_first_idx()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 116467aac55d9cbf55633b85915511c0c9256f55

[Gerrit Updater]

Mike Pershin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15835
Subject: LU-6714 llog: test plain llog more throughly
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1ed810ab336dad8881eb3507353697958ec4a708

[Peter Jones]

Landed for 2.8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/15316/
Subject: LU-6714 llog: fix wrong offset in llog_process_thread()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: df45994ddcf5e6fdc379b3e1d43f1d26ba321a0e

[Gerrit Updater]

Mike Pershin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15316
Subject: LU-6714 llog: fix wrong offset in llog_process_thread()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6a18e003fd97fb360a4a94d347895b1392d3022f

[Mikhail Pershin]

Link LU-5635 here as well to fix it properly