Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6835

lfs.c:481: error: implicit declaration of function 'futimes'

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.8.0
    • None
    • 3
    • 9223372036854775807

    Description

      Looks like a regression from http://review.whamcloud.com/15217 (a801262)

      [  280s] gcc -DHAVE_CONFIG_H -I. -I../..   -include /usr/src/packages/BUILD/cray-lustre/config.h -I/usr/src/packages/BUILD/cray-lustre/libcfs/include -I/usr/src/packages/BUILD/cray-lustre/lnet/include -I/usr/src/packages/BUILD/cray-lustre/lustre/include  -fPIC -D_GNU_SOURCE -D_LARGEFILE64_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DLUSTRE_UTILS=1 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -Werror -fno-stack-protector -I/opt/cray-hss-devel/7.3.0/include  -Werror -MT lfs.o -MD -MP -MF .deps/lfs.Tpo -c -o lfs.o lfs.c
[  280s] cc1: warnings being treated as errors
[  280s] lfs.c: In function 'migrate_copy_timestamps':
[  280s] lfs.c:481: error: implicit declaration of function 'futimes'

      I think lfs.c just needs to include sys/time.h.

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-6264 Enable strict compiler defence modes

          • Major - Major loss of function.
          • Resolved

          Activity

            [LU-6835] lfs.c:481: error: implicit declaration of function 'futimes'
            pjones Peter Jones added a comment -

            Landed for 2.8

            pjones Peter Jones added a comment - Landed for 2.8
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15392/
            Subject: LU-6835 build: add -Wall to CFLAGS for test/ and utils/
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: b80d263bed6d4756ecc471129822612104f01487

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15392/ Subject: LU-6835 build: add -Wall to CFLAGS for test/ and utils/ Project: fs/lustre-release Branch: master Current Patch Set: Commit: b80d263bed6d4756ecc471129822612104f01487
            simmonsja James A Simmons added a comment -

            As a suggestion we push a patch for the lnet utils as well that does the same thing.

            simmonsja James A Simmons added a comment - As a suggestion we push a patch for the lnet utils as well that does the same thing.
            simmonsja James A Simmons added a comment -

            Adding in the -Wall flag should prevent things like this in the future.

            simmonsja James A Simmons added a comment - Adding in the -Wall flag should prevent things like this in the future.
            jhammond John Hammond added a comment -

            This is also addressed by http://review.whamcloud.com/#/c/15392/.

            jhammond John Hammond added a comment - This is also addressed by http://review.whamcloud.com/#/c/15392/ .
            pjones Peter Jones added a comment -

            Bob

            Could you please look over this patch?

            Thanks

            Peter

            pjones Peter Jones added a comment - Bob Could you please look over this patch? Thanks Peter
            gerrit Gerrit Updater added a comment -

            Chris Horn (hornc@cray.com) uploaded a new patch: http://review.whamcloud.com/15563
            Subject: LU-6835 build: include sys/time.h in lfs.c
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 00287ec94fa409b94b6f52e544e86aa4af45cd2a

            gerrit Gerrit Updater added a comment - Chris Horn (hornc@cray.com) uploaded a new patch: http://review.whamcloud.com/15563 Subject: LU-6835 build: include sys/time.h in lfs.c Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 00287ec94fa409b94b6f52e544e86aa4af45cd2a

            People

              bogl Bob Glossman (Inactive)
              hornc Chris Horn
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: