[LU-7025] lfsck_layout_scan_stripes suspicious rc assignment

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.8.0
• Severity: 3
• Assignee: nasf (Inactive)
• Reporter: Oleg Drokin

Description

We seem to be having this sort of code there:

                if (lso == NULL) {
                        struct lu_attr *attr = &info->lti_la;

                        rc = dt_attr_get(env, parent, attr);
                        if (rc != 0) {
                                rc = PTR_ERR(lso);
                                goto next;
                        }

Now note that lso is already NULL - meaning we reset nonzero rc into zero in quite a roundabout way.
Are you sure this is what was desired? I think we should just reuse the rc with the error instead?