Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-7052

iovec created with iov_iter_get_pages_alloc must be freed with kvfree

Details

    • Bug
    • Resolution: Won't Fix
    • Minor
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      Commit 98883bd3e2cc48a3a5674ce140ad74bece37df05 added support for iov_iter_get_pages_alloc for newer kernels, instead of ll_get_user_pages. However the iovec was still freed within ll_free_user_pages, using OBD_FREE_LARGE. Use kvfree instead (like in the linux kernel).

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-7465 False positive memory leak in sanity tests due to iov_iter_get_pages_alloc

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-6260 more support for 3.16 linux kernel

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-7052] iovec created with iov_iter_get_pages_alloc must be freed with kvfree
            spitzcor Cory Spitz made changes -
            Link New: This issue is related to LU-7465 [ LU-7465 ]
            pjones Peter Jones made changes -
            Resolution New: Won't Fix [ 2 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            pjones Peter Jones added a comment -

            Hope I am understanding correctly that it is this ticket that can be closed

            pjones Peter Jones added a comment - Hope I am understanding correctly that it is this ticket that can be closed
            fzago Frank Zago (Inactive) added a comment -

            Thanks James. So that patch is not needed for head of tree then.

            That issue can be closed.

            fzago Frank Zago (Inactive) added a comment - Thanks James. So that patch is not needed for head of tree then. That issue can be closed.
            simmonsja James A Simmons added a comment -

            OBD_FREE thanks to LU-6587 handles freeing both vmalloc and kmalloc memory. It test if the memory in question was created with vmalloc. You will noticed OBD_FREE_LARGE is now a place holder for OBD_FREE.

            simmonsja James A Simmons added a comment - OBD_FREE thanks to LU-6587 handles freeing both vmalloc and kmalloc memory. It test if the memory in question was created with vmalloc. You will noticed OBD_FREE_LARGE is now a place holder for OBD_FREE.
            pjones Peter Jones made changes -
            Labels New: patch
            gerrit Gerrit Updater added a comment -

            frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/16111
            Subject: LU-7052 llite: free iovec with kvfree
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 91b253a4385f2884bee5abad383555c4b33a3222

            gerrit Gerrit Updater added a comment - frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/16111 Subject: LU-7052 llite: free iovec with kvfree Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 91b253a4385f2884bee5abad383555c4b33a3222
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-6260 [ LU-6260 ]
            fzago Frank Zago (Inactive) created issue -

            People

              wc-triage WC Triage
              fzago Frank Zago (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: